Skip to content

fix(grep): return chunks for release searches - #953

Open
AlexMikhalev wants to merge 2 commits into
task/2668-terraphim-lsp-foundationfrom
release-guardian/terraphim-grep-small-fixes
Open

fix(grep): return chunks for release searches#953
AlexMikhalev wants to merge 2 commits into
task/2668-terraphim-lsp-foundationfrom
release-guardian/terraphim-grep-small-fixes

Conversation

@AlexMikhalev

@AlexMikhalev AlexMikhalev commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • enables code-search in default terraphim-grep builds so release binaries have a real search backend
  • returns an explicit error when compiled without code-search instead of silently returning empty results
  • preserves returned chunks/concepts/stats when local retrieval is insufficient
  • degrades to search-only when the llm feature is disabled
  • adds a CLI known-match regression for chunks and stats

Verification

  • cargo test -p terraphim_grep --no-default-features --features code-search
  • cargo clippy -p terraphim_grep --no-default-features --features code-search -- -D warnings
  • cargo test -p terraphim_grep --test cli_known_match -- --nocapture
  • cargo install --locked --path crates/terraphim_grep --root /tmp/rg-grep-fixed-code-search --no-default-features --features code-search
  • smoke: fixture query returned chunks=1 and stats.chunks_returned=1

Notes

  • Default-feature path install still hits existing aws-lc-sys/GCC compiler guard tracked in Gitea #3171.
  • Fixes Gitea #3169 behavior on the source line where terraphim_grep exists.

@AlexMikhalev
fix(grep): return chunks for release searches
f049207 
- enable code-search in default terraphim-grep builds
- fail explicitly when compiled without code-search instead of returning empty results
- preserve chunks/concepts/stats for insufficient local retrieval
- degrade to search-only when llm feature is disabled
- add CLI known-match regression covering chunks and stats
@AlexMikhalev
test(grep): cover no-code-search CLI behavior
8bf952d 
- gate known-match CLI regression to code-search builds
- add no-code-search CLI regression for the explicit rebuild-with-code-search error
This was referenced Aug 7, 2026
Open
Closed
AlexMikhalev added a commit that referenced this pull request Aug 7, 2026
@AlexMikhalev
ci: unblock task branch checks
50dc2b2 
Fix the local base-branch CI blockers shared by PR #953/#954:
- apply rustfmt to pre-existing terraphim_rlm formatting drift
- replace Rust 1.91-only str::floor_char_boundary with MSRV-safe UTF-8 boundary logic for Rust 1.80
- harden Firecracker VM create diagnostics and error handling
- install cargo-nextest via the existing upstream installer pattern
- run cargo nextest directly so filter expression quoting survives rch

Verification:
- cargo fmt -- --check
- cargo test -p terraphim_rlm query_loop::tests::test_truncate -- --nocapture
- cargo clippy -p terraphim_rlm -- -D warnings
- Firecracker workflow YAML parsed and shell path simulated
- independent reviews passed
AlexMikhalev added a commit that referenced this pull request Aug 7, 2026
@AlexMikhalev
ci: unblock task branch checks
1f0b8e2 
Fix the local base-branch CI blockers shared by PR #953/#954:
- apply rustfmt to terraphim_rlm files that failed cargo fmt --check
- replace str::floor_char_boundary with MSRV-safe char-boundary logic
- harden Firecracker VM creation diagnostics with HTTP status/body logging
- keep cargo nextest filter expressions out of rch shell reconstruction
- install cargo-nextest with the upstream tarball installer on Firecracker runners
- isolate nextest failures with ephemeral server test ports and isolated direct-dispatch test state

Leaves the Firecracker VM lifecycle 401/capacity issue tracked separately in Gitea #3173.
AlexMikhalev added a commit that referenced this pull request Aug 7, 2026
@AlexMikhalev
ci: unblock task branch checks
a7735e6 
Fix the local base-branch CI blockers shared by PR #953/#954:
- apply rustfmt to terraphim_rlm files that failed cargo fmt --check
- replace str::floor_char_boundary with MSRV-safe char-boundary logic
- harden Firecracker VM creation diagnostics with HTTP status/body logging
- keep cargo nextest filter expressions out of rch shell reconstruction
- install cargo-nextest with the upstream tarball installer on Firecracker runners
- isolate nextest failures with ephemeral server test ports and isolated direct-dispatch test state
- run cargo-spawning MCP autocomplete E2E tests in a dedicated serial nextest step

Leaves the Firecracker VM lifecycle 401/capacity issue tracked separately in Gitea #3173.
AlexMikhalev added a commit that referenced this pull request Aug 7, 2026
@AlexMikhalev
ci: unblock task branch checks
2791ccd 
Fix the local base-branch CI blockers shared by PR #953/#954:
- apply rustfmt to terraphim_rlm files that failed cargo fmt --check
- replace str::floor_char_boundary with MSRV-safe char-boundary logic
- harden Firecracker VM creation diagnostics with HTTP status/body logging
- keep cargo nextest filter expressions out of rch shell reconstruction
- install cargo-nextest with the upstream tarball installer on Firecracker runners
- isolate nextest failures with ephemeral server test ports and isolated direct-dispatch test state
- run cargo-spawning MCP autocomplete E2E tests in a dedicated serial nextest step
- give performance benchmarks enough time to finish Criterion after service benchmarks

Leaves the Firecracker VM lifecycle 401/capacity issue tracked separately in Gitea #3173.
@AlexMikhalev

AlexMikhalev commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Base CI unblocker update: PR #955 now has the ownable/code gates green on head 2791ccd16cede02e46bcb4cfb13b32b9d1fe291d:

  • Native setup: success
  • Native lint-and-format: success
  • Firecracker Rust build + test: success
  • Performance Benchmarks + Regression Check: success

Only remaining red check on #955 is Firecracker VM lifecycle proof, now diagnosed as fcctl create status: 401 and tracked separately as Gitea #3173 (bigbox/fcctl-web auth/infra).

Recommendation: merge/rebase the base CI unblocker (#955) before judging this PR's checks; this PR's older CI runs include stale base failures that #955 fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AlexMikhalev