Refs #84: broaden workspace test gate to --tests --bins --examples --lib - #15
Conversation
SummaryThe native CI gate at The change is one line: The PR also adds an inline comment block explaining the rationale and pointing at #142/#143/#144 as the prerequisite fixes. The merge order is called out in the PR body: #142, #143, #144 should land first, then this PR keeps the gate honest going forward. What was done well: the verification path is documented (the PR body cites a local verification branch that merged #142, #143, #144 alongside this change, with What remains problematic: nothing structural. The one observation worth noting is that Confidence Score: 5/5
Important Files Changed
Inline FindingsNo P0, P1, or P2 findings. Observation (not a finding) Last reviewed commit: f0ab648 | Reviews (1) |
Replace 'cargo test --workspace --lib --no-fail-fast' with 'cargo test --workspace --tests --bins --examples --lib --no-fail-fast'. Why: the narrower --lib gate silently skipped crates/terraphim_mcp_server/tests/test_tools_list.rs and crates/terraphim_mcp_server/tests/test_all_mcp_tools.rs, which exercise real JSON-RPC round-trips against the terraphim_mcp_server binary. --tests --bins --examples adds those targets; --lib is retained so the existing crate-internal coverage continues to run. --no-fail-fast ensures all targets run even when one fails, so a single broken test does not hide the rest of the failures behind an early abort. Verified locally on a verification branch that merged #142, #143, and #144 alongside this change: 'cargo test --workspace --tests --bins --examples --lib --no-fail-fast' with TERRAPHIM_SERVER_BIN pointing at the v1.21.3 server binary exits 0 with zero FAILED test targets.
f0ab648 to
b13fff4
Compare
Refs #84: replaces
cargo test --workspace --lib --no-fail-fastwith
cargo test --workspace --tests --bins --examples --lib --no-fail-fastin
.gitea/workflows/native-ci.yml.Why: the narrower
--libgate silently skippedcrates/terraphim_mcp_server/tests/test_tools_list.rsandcrates/terraphim_mcp_server/tests/test_all_mcp_tools.rs, whichexercise real JSON-RPC round-trips against the
terraphim_mcp_serverbinary.
--tests --bins --examplesadds those targets;--libisretained so the existing crate-internal coverage continues to run.
--no-fail-fastensures all targets run even when one fails, so asingle broken test does not hide the rest of the failures behind an
early abort.
Local verification: on a verification branch that merged #142, #143,
and #144 alongside this change,
cargo test --workspace --tests --bins --examples --lib --no-fail-fastwithTERRAPHIM_SERVER_BINpointing at the v1.21.3 server binary exits 0 with zero FAILED test
targets.
Order of merging: #142, #143, #144 should land first so the
broadened gate has nothing to flag. Once they are in, this PR
keeps the gate honest going forward.