Skip to content

Reorganized tutorials book to include vignette section#81

Merged
dlebauer merged 96 commits intomasterfrom
traits_tutorials
Jan 29, 2019
Merged

Reorganized tutorials book to include vignette section#81
dlebauer merged 96 commits intomasterfrom
traits_tutorials

Conversation

@kimberlyh66
Copy link
Copy Markdown
Contributor

@kimberlyh66 kimberlyh66 commented Jan 23, 2019

Please review changes that I have made to include a vignette section. Some changes are old and for the traits tutorial.

kimberlyh66 and others added 30 commits November 5, 2018 13:58
Co-Authored-By: kimberlyh66 <44081116+kimberlyh66@users.noreply.github.com>
…rence. also updated comment on embedded shiny app (link to traitvis app does work).
…y_height'

-removed geom_smooth layer from ggplot
…bles chunk (running this chunk results in a HTTP 504 Gateway Timeout)
@dlebauer
Copy link
Copy Markdown
Member

dlebauer commented Jan 25, 2019

@kimberlyh66 can you resolve the merge conflicts so that I can finish up my review? I am not sure where the merge conflicts happened, but it seems that for the most part we want what is in the traits_tutorials branch to replace what is in master. You can either do it here: https://github.com/terraref/tutorials/pull/81/conflicts or if you want to take everything from this branch git checkout --ours PATH/FILE https://easyengine.io/tutorials/git/git-resolve-merge-conflicts

Copy link
Copy Markdown
Member

@dlebauer dlebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the steps required to get this to compile now? Are there changes in other branches that I need to merge in? For example, it seems that the file names listed in _bookdown.yml are inconsistent w/ the files in the vignettes folder

@kimberlyh66
Copy link
Copy Markdown
Contributor Author

I think you will need to merge in Kristina's branch (#85) as well as Chris' branch (#86). I will change the file names in _bookdown.yml to be consistent with those in the vignettes folder.

kimberlyh66 and others added 7 commits January 28, 2019 12:19
Merge branch 'traits_tutorials' of github.com:terraref/tutorials into traits_tutorials

# Conflicts:
#	_bookdown.yml
Co-Authored-By: Chris-Schnaufer <schnaufer@email.arizona.edu>
* set python engine to python3
Comment thread vignettes/01-get-trait-data-R.Rmd Outdated
Comment thread traits/02-betydb-api-access.Rmd
Comment thread traits/04-danforth-indoor-phenotyping-facility.Rmd
@dlebauer dlebauer merged commit 88ea83a into master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants