Upgrade Symphonia dependency to 0.6.0 - #157
Conversation
|
Please run |
|
Hey, I've addressed your feedback! Removed the UnexpectedEof special case in from_file.rs and ran rustfmt, turns out no changes were needed since the code was already following the project's formatting. All 98 tests pass. Let me know what you think! |
| .try_into() | ||
| .expect("could not convert u64 into usize")) | ||
| let actual = seeked_to.actual_ts.get(); | ||
| Ok(if actual < 0 { |
There was a problem hiding this comment.
Is this an actual thing that can happen? Can the timestamp be less than zero or more than the number of frames?
There was a problem hiding this comment.
OK I did some investigation on this. mp3 and ogg files can start at and seek to negative timestamps. I tried changing Decoder::seek to return an i64 timestamp, but this lead to a bug with looping streaming sounds where the decoder would run out of frames before the decoder_current_frame_index reached num_frames. So in practice, this seems to be a good way to handle negative timestamps.
|
thank you for the PR! |
2 participants
Updated Symphonia from 0.5.4 to 0.6.0.
I tested the upgrade locally and did not encounter issues during playback testing.
I also ran
cargo test, and all tests passed successfully.Since there was a previous note mentioning that updating Symphonia would require investigation into the changes, I wanted to share this update in case it helps.