Kitchen::Base and Windows support

[jjasghar]

This PR is for Windows and Kitchen::Base support.

• Updating Fog to newest
• Updating test-kitchen to newest
• Removing Cane
• Added better wording for key injection for README.

[tfitch]

FYI - one of my customers is excited about this change and will be trying it out once it is available.

[adamleff]

I'd create a helper method for the hints path:

def hints_path
  Ohai::Config[:hints_path][0]
end

... and use that here so you're not having to dissect an array twice.

[jjasghar]

Need to add this due to 1.4 tk.

[usepowershell]

If username and password are available in the state file (from the driver), you don't need to add them to transport, unless you want to connect with a different account.

[jjasghar]

Yeah I'd like to keep this in the readme, but that's good to know. I know with my image i had to put a different administrator password in.

[usepowershell]

Where would this option ever get set? I don't see a configuration option in your driver or the base driver for :disable_ssl_validation

[jjasghar]

So it's mentioned in the README, about being turned on ONLY if you know what you're doing. I don't think it's supposed to be used or acknowledged without specific reasons.

[adamleff]

To @smurawski's point, while TK doesn't complain if you pass in configuration options that are not specified, it's good practice to define a default so the code self-documents the fact that options are available.

I'd recommend putting this at the top of your class:

default_config :disable_ssl_validation, false

That way it's 100% clear what the intention is, and you never have to worry about an edge case where this being nil bites you :)

[mwrock]

LGTM but odd that winrm flaps at the beginning causing a need for the winrm_wait. what win version are you testing with? Was the image sysprepped to run a script on initial startup that might restart winrm?

[usepowershell]

You could offer windows equivalents of these commands. mkdir could just be "mkdir #{hints_path}" and touch could be " '' > #{hints_path}\\openstack.json" (just off the top of my head.

[usepowershell]

@mwrock The flaps are likely due to the cloud-init process as the instance is created. @jjasghar I'm pretty 👍 with a few minor nitpicks.

[jjasghar]

Added this to the readme for #77

[adamleff]

I'd suggest making this a little clearer...

Test Kitchen 1.4 supports multiple transports, and transports can be configure globally:

transport:
  username: ubuntu
  password: mysecretpassword

... or per-platform:

platforms:
  name: ubuntu-14.04
  transport:
    password: myrootpassword
  name: windows-2012r2
    password: myadministratorpassword

[jjasghar]

Nice, done.