Implement ID fields for StackTrace and Callframes#54
Merged
josephburgess merged 9 commits intotesterloop:masterfrom Jun 7, 2023
Merged
Implement ID fields for StackTrace and Callframes#54josephburgess merged 9 commits intotesterloop:masterfrom
josephburgess merged 9 commits intotesterloop:masterfrom
Conversation
meiamsome
previously approved these changes
May 25, 2023
josephburgess
force-pushed
the
adding-ID-Node-StackTrace
branch
from
528a818 to
0db7c13
Compare
josephburgess
changed the title
meiamsome
reviewed
May 31, 2023
Comment on lines
42
to
46
Contributor
There was a problem hiding this comment.
This is actually a bit anti-patterny in the old code, we should probably move this to the StackTrace.callFrames resolver, you will need add a mapper for StackFrame that is just id based.
meiamsome
previously approved these changes
Jun 5, 2023
meiamsome
previously approved these changes
Jun 5, 2023
meiamsome
previously approved these changes
Jun 5, 2023
meiamsome
reviewed
Jun 5, 2023
Contributor
There was a problem hiding this comment.
It might be worth changing this to consoleLogEvent: ConsoleLogEventModel to make it clearer what's going on?
meiamsome
approved these changes
Jun 5, 2023
josephburgess
force-pushed
the
adding-ID-Node-StackTrace
branch
from
43b0863 to
b6fe319
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.