Implement ID fields for StackTrace and Callframes

codegen.yml

@@ -22,6 +22,7 @@ generates:
         URL: string
       mappers:
         ConsoleLogEvent: ./mappers#ConsoleLogEventModel
+        StackTrace: ./mappers#StackTraceModel
         HttpNetworkEvent: ./mappers#HttpNetworkEventModel
         StepEvent: ./mappers#StepEventModel
         StepEventEdge: ./mappers#StepEventEdgeModel

src/resolvers/CallFrame.ts

@@ -1,10 +1,11 @@
 import { CallFrameResolvers } from './types/generated'
 
 const resolvers: CallFrameResolvers = {
-    columnNumber: (parent) => parent.columnNumber,
+    id: ({ id }) => id,
     functionName: (parent) => parent.functionName,
     lineNumber: (parent) => parent.lineNumber,
     url: (parent) => parent.url,
+    columnNumber: (parent) => parent.columnNumber,
 };
 
 export default resolvers

src/resolvers/ConsoleLogEvent.ts

@@ -1,8 +1,10 @@
 import { assertNonNull } from '../util/assertNonNull.js';
 import { ConsoleLogEventResolvers, ConsoleLogLevel } from './types/generated.js';
-
+import { encodeId } from '../util/id.js';
 const resolvers: ConsoleLogEventResolvers = {
-    id: ({ id }) => id,
+    id({ id }) {
+        return encodeId('ConsoleLogEvent', id);
+    },
     async at({ id }, _args, { dataSources }) {
         const event = assertNonNull(await dataSources.consoleEvent.getById(id));
         return event.timestamp;
@@ -36,13 +38,9 @@ const resolvers: ConsoleLogEventResolvers = {
     },
     async stackTrace({ id }, _args, { dataSources }) {
         const event = assertNonNull(await dataSources.consoleEvent.getById(id));
-        const callFrames = event.stackTrace.callFrames.map((callFrame) => ({
-            __typename: 'CallFrame' as const,
-            ...callFrame,
-        }));
         return {
             __typename: 'StackTrace',
-            callFrames: callFrames,
+            id: id,
         };
     },
     async testExecution({ id }, _args, { dataSources }) {

src/resolvers/Query.ts

@@ -79,7 +79,7 @@ const resolvers: QueryResolvers = {
             id: decodedId,
         };
     },
-
+    
     async node(root, { id }, context, info) {
         const decodedId = decodeId(id);
         if (!decodedId) {

src/resolvers/StackTrace.ts

@@ -1,9 +1,19 @@
-import  {StackTraceResolvers} from './types/generated';
-
+import { StackTraceResolvers } from './types/generated';
+import { assertNonNull } from '../util/assertNonNull.js';
 
 
 const resolvers: StackTraceResolvers = {
-    callFrames: (parent) => parent.callFrames,
+    id: ({ id }) => `${id}/stack`,
+    async callFrames(parent, _args, { dataSources }) {
+        const eventId = parent.id
+        const event = assertNonNull(await dataSources.consoleEvent.getById(eventId));
+        const callFrames = event.stackTrace.callFrames.map((callFrame, idx) => ({
+            __typename: 'CallFrame' as const,
+            id: `${event.id}/stack/${idx}`,
+            ...callFrame,
+        }));
+        return callFrames;
+    },
 };
 
-export default resolvers
+export default resolvers;

src/resolvers/types/generated.ts

@@ -1,5 +1,5 @@
 import { GraphQLResolveInfo, GraphQLScalarType, GraphQLScalarTypeConfig } from 'graphql';
-import { ConsoleLogEventModel, HttpNetworkEventModel, StepEventModel, StepEventEdgeModel, StepEventConnectionModel, ScenarioEventModel, TestExecutionModel, TestExecutionConnectionModel, TestExecutionEdgeModel, TestExecutionEventConnectionModel, TestExecutionEventEdgeModel, TestRunModel, TestRunConnectionModel, TestRunEdgeModel, GitHubRevisionModel, CommandChainEventModel, CommandChainEventEdgeModel, CommandChainEventConnectionModel, CommandEventModel, CommandEventEdgeModel, CommandEventConnectionModel, TestExecutionSnapshotModel, TestExecutionScreenshotModel, GitHubRevisionFileModel, GitHubRevisionFileLineModel, GitHubRevisionFileLineColumnModel, SourceCodeManagementRevisionFileLineColumnModel } from './mappers';
+import { ConsoleLogEventModel, StackTraceModel, HttpNetworkEventModel, StepEventModel, StepEventEdgeModel, StepEventConnectionModel, ScenarioEventModel, TestExecutionModel, TestExecutionConnectionModel, TestExecutionEdgeModel, TestExecutionEventConnectionModel, TestExecutionEventEdgeModel, TestRunModel, TestRunConnectionModel, TestRunEdgeModel, GitHubRevisionModel, CommandChainEventModel, CommandChainEventEdgeModel, CommandChainEventConnectionModel, CommandEventModel, CommandEventEdgeModel, CommandEventConnectionModel, TestExecutionSnapshotModel, TestExecutionScreenshotModel, GitHubRevisionFileModel, GitHubRevisionFileLineModel, GitHubRevisionFileLineColumnModel, SourceCodeManagementRevisionFileLineColumnModel } from './mappers';
 import { Context } from '../../context';
 export type Maybe<T> = T | null;
 export type InputMaybe<T> = Maybe<T>;
@@ -35,6 +35,7 @@ export type CallFrame = {
   readonly __typename: 'CallFrame';
   readonly columnNumber: Scalars['Int'];
   readonly functionName: Scalars['String'];
+  readonly id: Scalars['ID'];
   readonly lineNumber: Scalars['Int'];
   readonly url: Scalars['URL'];
 };
@@ -579,6 +580,7 @@ export type SourceCodeManagementRevisionFileLineColumn = {
 export type StackTrace = {
   readonly __typename: 'StackTrace';
   readonly callFrames: ReadonlyArray<CallFrame>;
+  readonly id: Scalars['ID'];
 };
 
 export type StepDefinition = {
@@ -887,7 +889,7 @@ export type ResolversTypes = {
   SourceCodeManagementRevisionFile: ResolversTypes['GitHubRevisionFile'];
   SourceCodeManagementRevisionFileLine: ResolversTypes['GitHubRevisionFileLine'];
   SourceCodeManagementRevisionFileLineColumn: ResolverTypeWrapper<SourceCodeManagementRevisionFileLineColumnModel>;
-  StackTrace: ResolverTypeWrapper<StackTrace>;
+  StackTrace: ResolverTypeWrapper<StackTraceModel>;
   StepDefinition: ResolverTypeWrapper<StepDefinition>;
   StepEvent: ResolverTypeWrapper<StepEventModel>;
   StepEventConnection: ResolverTypeWrapper<StepEventConnectionModel>;
@@ -981,7 +983,7 @@ export type ResolversParentTypes = {
   SourceCodeManagementRevisionFile: ResolversParentTypes['GitHubRevisionFile'];
   SourceCodeManagementRevisionFileLine: ResolversParentTypes['GitHubRevisionFileLine'];
   SourceCodeManagementRevisionFileLineColumn: SourceCodeManagementRevisionFileLineColumnModel;
-  StackTrace: StackTrace;
+  StackTrace: StackTraceModel;
   StepDefinition: StepDefinition;
   StepEvent: StepEventModel;
   StepEventConnection: StepEventConnectionModel;
@@ -1025,6 +1027,7 @@ export type BrowserVersionResolvers<ContextType = Context, ParentType extends Re
 export type CallFrameResolvers<ContextType = Context, ParentType extends ResolversParentTypes['CallFrame'] = ResolversParentTypes['CallFrame']> = {
   columnNumber: Resolver<ResolversTypes['Int'], ParentType, ContextType>;
   functionName: Resolver<ResolversTypes['String'], ParentType, ContextType>;
+  id: Resolver<ResolversTypes['ID'], ParentType, ContextType>;
   lineNumber: Resolver<ResolversTypes['Int'], ParentType, ContextType>;
   url: Resolver<ResolversTypes['URL'], ParentType, ContextType>;
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
@@ -1414,6 +1417,7 @@ export type SourceCodeManagementRevisionFileLineColumnResolvers<ContextType = Co
 
 export type StackTraceResolvers<ContextType = Context, ParentType extends ResolversParentTypes['StackTrace'] = ResolversParentTypes['StackTrace']> = {
   callFrames: Resolver<ReadonlyArray<ResolversTypes['CallFrame']>, ParentType, ContextType>;
+  id: Resolver<ResolversTypes['ID'], ParentType, ContextType>;
   __isTypeOf?: IsTypeOfResolverFn<ParentType, ContextType>;
 };
 

src/resolvers/types/mappers.ts

@@ -5,6 +5,11 @@ export interface ConsoleLogEventModel {
     id: string,
 }
 
+export interface StackTraceModel {
+    __typename: 'StackTrace',
+    id: string,
+}
+
 export interface HttpNetworkEventModel {
     __typename: 'HttpNetworkEvent',
     id: string,

src/schema/execution/console/StackTrace.graphql

@@ -1,10 +1,12 @@
 type CallFrame {
+    id: ID!
     functionName: String!
     url: URL!
     lineNumber: Int!
     columnNumber: Int!
 }
 
 type StackTrace {
+    id: ID!
     callFrames: [CallFrame!]!
 }