Skip to content

Fix options types for extend API #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Fix options types for extend API #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions test/extend.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,23 @@ describe('lib/extend.ts', () => {
expect(text).toEqual(['Hello h1', 'Hello h2', 'Hello h3'])
})

it('should handle the queryAll* methods with a selector', async () => {
const elements = await document.queryAllByText(/Hello/, {selector: 'h2'})
expect(elements).toHaveLength(1)

const text = await page.evaluate(el => el.textContent, elements[0])

expect(text).toEqual('Hello h2')
})

it('should handle the getBy* methods with a selector', async () => {
const element = await document.getByText(/Hello/, {selector: 'h2'})

const text = await page.evaluate(el => el.textContent, element)

expect(text).toEqual('Hello h2')
})

it('should scope results to element', async () => {
const scope = await document.$('#scoped')
const element = await scope!.queryByText(/Hello/)
Expand Down