"findByRole" query over "waitFor and getByRole" #1189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By implementing tis change, the eslint suggestion "Prefer `findByRole` query over using `waitFor` + `getByRole" is removed. The change implements the recommended suggestions by these two articles, which is the same as the automatic command line "quickfix." [1] https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/prefer-find-by.md [2] https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#using-waitfor-to-wait-for-elements-that-can-be-queried-with-find
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
timdeschryver
left a comment
timdeschryver
left a comment
There was a problem hiding this comment.
Thanks!
Could you also update the other examples on this page?
For example on line 113, 139, and 213.
| fireEvent.click(screen.getByText('Load Greeting')) | ||
|
|
||
| await waitFor(() => screen.getByRole('heading')) | ||
| await screen.findByRole('heading') |
Member
There was a problem hiding this comment.
The waitFor import on line 77 can be removed.
Contributor
|
I think this could be closed in favor of #1242 |
Member
|
You're right, thanks @ledenis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By implementing tis change, the eslint suggestion "Prefer
findByRolequery over usingwaitFor+ `getByRole" is removed. The change implements the recommended suggestions by these two articles, which is the same as the automatic command line "quickfix." [1] https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/prefer-find-by.md[2] https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#using-waitfor-to-wait-for-elements-that-can-be-queried-with-find