Skip to content

Conversation

@smk267
Copy link
Contributor

@smk267 smk267 commented Nov 22, 2023

This PR does the following:

@netlify
Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit d4107cf
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/655eb3027b2c1900085e77c5
😎 Deploy Preview https://deploy-preview-1342--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems to be working like a charm!
I left a small comment.

@nickserv
Copy link
Member

Thanks! For future reference, there's no need to prefix your branch with all-contributors/smk267, that's just the branch that our @all-contributors bot creates to credit your work.

@testing-library testing-library deleted a comment from allcontributors bot Nov 23, 2023
@nickserv nickserv linked an issue Nov 23, 2023 that may be closed by this pull request
Copy link
Member

@nickserv nickserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new redirect is broken in development, but I'm ok with merging since it fixes the issue in production.

@timdeschryver timdeschryver merged commit baa24a1 into testing-library:main Nov 23, 2023
@timdeschryver
Copy link
Member

@all-contributors please add @smk267 for infra

@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @smk267! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search engine optimization is worse for user-event 14 than 13

3 participants