Silence unused-result warnings in the E2E opponent bot#27
Merged
Conversation
.glassProminent/.glass only exist in the iOS 26 SDK, and #available is a runtime check — building with Xcode 16 (the CI runner's toolchain) failed to resolve the symbols. A #if compiler(>=6.2) gate compiles the bordered fallbacks on older toolchains while Xcode 26 builds keep the glass styles behind the runtime check. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The bot now offers a rematch after the first game; the UI test accepts it from the game-over sheet, verifies a fresh game starts (sheet dismisses, colors swapped), plays and resigns the second game, and then reviews. Self-skips in CI like the rest of the online suite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Two `try? game.play(...)` calls in OnlineMatchUITests discarded their HistoryEntry result, leaving the only warnings in the test build. Explicitly discard with `_ =`; verified against a live local server (full match + rematch flow passes). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
testtest126
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two-line cleanup from the Swift 6 warning pass: explicitly discard
game.play(uci:)results in the E2E opponent bot. (This PR reuses the fix/ios-ci-glass-styles branch; its first two commits are already on main via #24 and #26 — the real diff vs main is only this cleanup.)