Security fast-follow: SIWA review findings R1-R3#57
Merged
Conversation
…test Addresses the three required findings from the rule-5 security review of PR #50, which merged before this delta could land on its branch: R1: the link path could rebind an already-linked account to a different Apple ID — a stolen bearer would lock the real owner's Apple sign-in out of recovery. Linking now requires the account to be unlinked (or already linked to the same subject) and returns 409 otherwise. R2: a presented-but-invalid bearer was treated as anonymous, silently turning a guest's linking attempt into a fresh account permanently bound to their Apple ID. An Authorization header that fails verification now 401s; only a truly absent header proceeds anonymously. R3: regression test for the founding incident — a well-formed JWT signed with the server's own HMAC key must be rejected by the live Apple verifier (the original implementation accepted exactly this). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
testtest126
added a commit
that referenced
this pull request
Jul 10, 2026
Rule 4 rewritten: only the authoring session (or orchestrator on request) merges; blocking verdicts and unresolved review threads must be checked before merging. Rule 5 hardened: security PRs stay in draft until an explicit 'Security review: APPROVE @ <head>' comment from a second session, with BLOCKs posted as line-level review comments so branch protection's conversation-resolution requirement gates the merge mechanically. Adds the #28 deployment gate on open security issues and releases the main-checkout single-writer hold. Prompted by PR #50 and PR #57 both merging past a pending security review; branch protection (green checks + conversation resolution, admins included) is now active on main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
Security review: APPROVE @ 58ad316 Full findings and runtime evidence: #56 (comment) (verdict comment on #56, which is closed). Summary: R1 rebind guard (409, idempotent same-subject relink allowed, original binding survives attempted takeover), R2 strict bearer handling (present-but-invalid → 401 before account resolution), R3 incident-class forgery regression test (own-HMAC-signed well-formed JWT rejected via the live verifier path) — all verified in code and observed passing at this head. Non-blocking hardening remains tracked in #53. 🤖 Generated with Claude Code |
testtest126
added a commit
that referenced
this pull request
Jul 10, 2026
…te (#58) Rule 4 rewritten: only the authoring session (or orchestrator on request) merges; blocking verdicts and unresolved review threads must be checked before merging. Rule 5 hardened: security PRs stay in draft until an explicit 'Security review: APPROVE @ <head>' comment from a second session, with BLOCKs posted as line-level review comments so branch protection's conversation-resolution requirement gates the merge mechanically. Adds the #28 deployment gate on open security issues and releases the main-checkout single-writer hold. Prompted by PR #50 and PR #57 both merging past a pending security review; branch protection (green checks + conversation resolution, admins included) is now active on main. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #50 merged at afe32d2 before the rule-5 review's three required fixes could land on its branch, so main briefly carries them — this is the immediate fast-follow. ~20 lines of product code, exactly the reviewer's scope:
resolveAppleUsernow refuses to rebind an already-linked account to a different Apple ID (409 Conflict); re-presenting the same subject stays idempotent. Test proves the original binding survives a rebind attempt and still recovers the account.Authorizationheader that fails verification now 401s instead of being treated as anonymous — an expired bearer can no longer silently demote a linking request into a fresh account bound to the user's Apple ID.Non-blocking reviewer notes (nonce replay hardening, first-link race) are deliberately excluded per the orchestrator — tracked separately.
Test plan
🤖 Generated with Claude Code