fix(AppShell): editor toolbar tweaks (Home routing, Discord/GitHub links, autocapitalize) - #1910
Merged
Conversation
Mobile/tablet keyboards were auto-capitalizing the first letter typed into script expressions, attribute values, and other fields where case matters, silently corrupting scripting keywords and identifiers.
The Home button previously went to root, which is the Play tab when PUBLIC_SHOW_HOME is true — a dead end for someone mid-edit, since they got to the editor from Create in the first place. Also wraps the toolbar's filename/save-chip cluster in a flex container and cleans up save-chip button styling (no border, inherited font).
Small icon links next to the Quest Viva logo, visible on both the Play and Create tabs whenever the shell has its own chrome (Electron desktop app and play.questviva.com) — matching the GitHub Discussions/Discord links on the v5 desktop app's welcome screen.
They previously only appeared in HomeHeader (Play/Create tabs), so they'd vanish once you opened a game and landed on /edit. Toolbar.svelte now shows the same two links at the end of its trailing button cluster, same corner as HomeHeader, gated on the same PUBLIC_SHOW_HOME flag already used for its Home button. Also factors the icon SVGs out into DiscordIcon.svelte/GithubIcon.svelte (lucide, the icon set otherwise used throughout AppShell, deliberately ships no brand/logo icons) now that they're needed in two places.
Unlike HomeHeader (only rendered when PUBLIC_SHOW_HOME is true to begin with), the Toolbar is the one place that's always present regardless of deployment — gating it on that flag was an unverified assumption that textadventures.co.uk's surrounding site chrome already links out to Discord/GitHub. Just show them unconditionally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showHome)/open) instead of rootTest plan
npm run devinsrc/AppShelland confirm Home button navigates to/opentests/e2e/verify-appshell-home-button.mjsandtests/e2e/verify-appshell-home-header-links.mjspass🤖 Generated with Claude Code