fix(Engine): shorten Status Attributes editor prompts to fit the UI - #1963
Merged
Conversation
The stringdictionary keyprompt/valueprompt templates for the game and
object Status Attributes editors were full sentences ("Please enter
the attribute name" / "Please enter the format string (blank for
default)") written for a different UI. AppShell now renders them as
placeholder text in a narrow key field and a value field, where the
long sentences don't fit or read well. Shortened across all three
editor languages that define them (English/German/Spanish).
Also normalizes EditorEspanol.aslx from UTF-16LE to UTF-8+BOM to match
every other .aslx file in Core/Languages — the odd encoding made git
treat any change to that file as a binary diff.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
alexwarren
enabled auto-merge (squash)
July 30, 2026 07:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keyprompt/valueprompttext for the game and object Status Attributes editors (EditorGameAttributesPleaseenter[2]/EditorObjectAttributesPleaseenter[2]) across English, German, and Spanish — PR #1957 recently started rendering these as actual input placeholders in AppShell'sPropertyEditor.svelte, and the old full-sentence prompts ("Please enter the attribute name" / "Please enter the format string (blank for default)") didn't fit the narrow key field or read well as placeholders.EditorEspanol.aslxfrom UTF-16LE to UTF-8+BOM, matching every other.aslxfile underCore/Languages— it was the only UTF-16 file in that directory, which made git/GitHub treat any change to it as a binary diff.Test plan
dotnet build src/WasmEditor/WasmEditor.csprojsucceedsdotnet test tests/EngineTests --configuration Release— 279/279 passed