feat(Checkbox): add asFlexbox prop to allow for different layout styles - #756
Merged
Merged
Conversation
mukiienko
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using checkboxes in LabelPicker in browsers that show scroll bars in the traditional way (not as overlays) the layout breaks and labels are displayed in a separate line from the checkbox itself. In order to fix this, we need the checkbox to be in a flexbox. However, this as default behaviour can negatively effect already existing implementations. Hence this option is added via a new prop.
This new prop is now used in LabelPicker.
This PR also fixes a small bug with passing
styleandclassNameto Checkbox that were applied to the wrong HTML element.Checklist