Bump Bundle Support pin so stale installs receive tm/gems - #30
Merged
Conversation
Fixes #29: the GitHub Markdown preview died with a LoadError on machines whose managed Bundle Support predates 2026-06-08. tm/gems.rb landed only in the app's embedded copy back then — the pin never changed, and mandatory bundles are re-copied from the app only when the pin changes (BundleRegistry.mm alreadyAtPinnedSHA). Meanwhile Markdown (GitHub) auto-updates and now requires tm/gems. The library (and the Markdown (GitHub) default-bundle promotion from #23, which had the same drift) is now actually upstream: bundle-support.tmbundle#3 and #4. This pin bump delivers it: on next launch the SHA mismatch triggers a fresh copy from the embedded bundle, healing every stale install. Verified: refetching at the new pin reproduces the embedded content byte-for-byte; a stale registry (installedSHA 8ca9ddb0) re-copied on launch and the GFM preview pipeline renders through the refreshed managed copy.
This was referenced Jun 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29. Two one-line changes: the Bundle Support pin in
MandatoryBundles.hmoves from8ca9ddb0to686adb59, and the embedded copy's.shamarker follows.Why a pin bump fixes a LoadError: mandatory bundles are only ever copied out of the app, and the copy is skipped while
installedSHAequals the pin (BundleRegistry.mm,alreadyAtPinnedSHA).tm/gems.rblanded in the embedded copy on 2026-06-08 without a pin change, so installs from earlier builds never received it — while the auto-updating Markdown (GitHub) bundle now requires it (redcarpet.rb:17). Evidence from the affected machine in #29: Bundle Support frozen at 2026-05-25, Markdown (GitHub) updated 2026-06-11.The drifted content is now actually upstream (bundle-support.tmbundle#3: tm/gems + tests; #4: the Markdown (GitHub) default-bundle promotion from #23). The new pin both delivers it and heals every stale install: the SHA mismatch triggers a fresh copy on next launch.
Testing
bin/fetch_embedded_bundles.shat the new pin reproduces the embedded content byte-for-byte (only.shachanges)ninja BundlesManager/testgreen; full app buildsinstalledSHA 8ca9ddb0re-copied on launch (686adb59, freshinstalledAt), and the GFM preview pipeline (redcarpet.rb→tm/gems→ shared store → redcarpet+rouge) renders through the refreshed managed copyruby gems_test.rbunder system Ruby 2.6: 7 runs, 19 assertions, 0 failures