Pin actions/checkout to a full commit SHA - #35
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses D3 in
FIXES.md.What
Pins
actions/checkoutto a full commit SHA inbuild-and-test.yml(×2) andrelease.yml(×1). The# v5trailing comment keeps the human-readableversion visible.
Why
A version tag is a moving pointer. Whoever controls the upstream repo can
repoint
v5at different code, and every workflow referencing it picks that upon the next run — with this repo's Apple signing secrets in scope. A full SHA
is immutable.
actions/checkout'sv5was verified to be a lightweight tag pointingdirectly at commit
fbc6f39, so the SHA above is the commit, not a tag object.Blocks D3
sha_pinning_requiredcannot be turned on for this repo until this merges — itwould fail the workflows as currently written. Once merged:
Verification
All three workflows re-parsed with
ruby -ryamlafter the edit. Localreusable-workflow references (
./.github/workflows/build-and-test.yml) areuntouched — they are exempt from both allowlist and pinning rules.
Risk
Low. Same action, same version, immutable reference. No logic changed.