Remove the SyntaxMate XPC service - #40
Merged
Merged
Conversation
(cherry picked from commit 8c0dae1)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the SyntaxMate XPC service, at the request of its author.
Why
SyntaxMate is an XPC service that hands a syntax-highlighted
NSAttributedStringback to a calling application. Vadim Shpakovski contributed it in 2016 and asked for its removal in 2023 (textmate#1462):That PR is still open upstream. This applies his commit to our fork, authorship preserved.
I checked the state of it here before agreeing:
TextMate.app.build-and-test.ymlandrelease.ymlboth runninja TextMate, which does not reach theSyntaxMatetarget. It could have been broken for years without anyone noticing.Applications/SyntaxMate/resources/SyntaxMate.tmBundlepoints atshpakovski/syntaxmate.tmbundle, archived since 2016-11-13. It still resolves today, but it is an unowned single point of failure in every recursive clone — the same failure mode that currently makes textmate#1469 unbuildable for anyone but its author..tmLanguagefiles in every clone, for a target nobody builds.SyntaxMateImpl.mmusesinitForReadingWithData:, deprecated since macOS 10.14.In fairness to the other side: it does still build.
ninja SyntaxMatecompletes and signsSyntaxMate.xpccleanly on macOS 26.5 / Xcode 26.4. This is not bitrot — it is a working component with no consumer, kept alive by luck rather than by CI. If we ever want a third-party integration surface again, the code is recoverable from history, and it would need to come back with CI coverage and vendored grammars rather than an archived submodule.What
This drops our submodule count from 7 to 6.
Verification
macOS 26.5, Xcode 26.4.
grep -rn SyntaxMateacross*.rave,*.yml,*.mdand all sources: no dangling references../configure,SyntaxMateis no longer a ninja target (was 6:SyntaxMate,/debug,/release,/run, …).ninja TextMate— exit 0, clean.git submodule update --init --recursive— exit 0, six submodules, noApplications/SyntaxMate. This is the check that matters for a submodule removal, and it is the one that would have caught the broken pins in My take on modernizing TextMate textmate/textmate#1469.