Replace ruby18 shebangs with the system ruby - #47
Merged
Conversation
macOS has no `ruby18`. On macOS 26.5 `/usr/bin/ruby` is 2.6.10 and
nothing named `ruby18` is on PATH, so every command carrying that
shebang dies at exec with:
env: ruby18: No such file or directory
Two sites in this repo:
* Avian.tmbundle — shipped in Contents/SharedSupport/Bundles and has
no upstream repo of its own, so it is fixed in place.
* The Bundle Editor command templates, which were minting a ruby18
shebang into every newly created command and drag command.
Source.tmbundle carries the same shebang but is vendored by
bin/fetch_embedded_bundles.sh at the SHA pinned in
Frameworks/BundlesManager/src/MandatoryBundles.h. It follows once
textmatelives/source.tmbundle#1 merges and the pin is bumped.
Refs #45
Ruby 2.6 prints
warning: -K is specified; it is for 1.8 compatibility and may cause odd behavior
on stderr for every single run. Dropping the flag outright is not enough:
with no locale set, Encoding.default_external falls back to US-ASCII,
which is exactly what -KU was there to prevent. -Eutf-8 asks for the same
thing in 1.9+ terms.
Covers the four Avian commands, both Bundle Editor templates and
bin/show_log.
Refs #45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS has no
ruby18. On macOS 26.5/usr/bin/rubyis 2.6.10 and nothing namedruby18is on PATH, so every command carrying that shebang dies at exec withenv: ruby18: No such file or directory(exit 127).Two sites in this repo:
Avian.tmbundle(4 commands) — shipped inContents/SharedSupport/Bundlesand has no upstream repo of its own, so it is fixed in place.Frameworks/BundleEditor/templates/Command.plist,Drag Command.plist) — these were minting aruby18shebang into every newly created command and drag command, so the problem kept regenerating itself.Applications/TextMate/support/Bundles/Source.tmbundlecarries the same shebang but is deliberately left alone here: it is vendored bybin/fetch_embedded_bundles.shat the SHA pinned inFrameworks/BundlesManager/src/MandatoryBundles.h, and hand-editing it would desync the.shamarker. It follows once textmatelives/source.tmbundle#1 merges and the pin is bumped.The other 15 bundle repos are covered by companion PRs (48 files total).
Refs #45