release.yml: re-seal nested bundles before signing outer .app - #7
Merged
Conversation
Run 26369885190 failed at the Verify codesign + hardened runtime step: TextMate.app: a sealed resource is missing or invalid file modified: …/PlugIns/Dialog.tmplugin/Contents/Resources/tm_dialog In subcomponent: …/PlugIns/Dialog.tmplugin The Re-sign every embedded Mach-O step finds tm_dialog (and other nested binaries) via the */PlugIns/* path glob and codesigns each one. That invalidates the CodeResources seal of the enclosing .tmplugin — .tmplugin is itself a signed bundle, not just a directory. The next step re-signs the outer .app but never re-seals the intermediate bundles, so verify catches the broken seal. Codesigning requires inside-out ordering: leaf Mach-O → nested bundles → outer .app. Adding a new step between Mach-O re-sign and the outer-.app re-sign that re-codesigns every .tmplugin, .framework, .qlgenerator, and .appex bundle in the tree (currently three: Dialog.tmplugin, Dialog2.tmplugin, TextMateQL.qlgenerator).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the codesign verify failure in run 26369885190:
The "Re-sign every embedded Mach-O" step finds
tm_dialogvia the*/PlugIns/*glob and codesigns it. That invalidatesDialog.tmplugin's CodeResources seal —.tmpluginis itself a signed bundle. The next step re-signs the outer .app but never re-seals the intermediate.tmplugin, so verify catches the broken seal.Codesigning needs inside-out ordering: leaf Mach-O → nested bundles → outer .app. Adds a new step between the Mach-O re-sign and the outer-.app re-sign that codesigns every
.tmplugin,.framework,.qlgenerator, and.appexdirectory underContents/. Currently three:Dialog.tmplugin,Dialog2.tmplugin,TextMateQL.qlgenerator.Test plan
build-testpasses on this PRworkflow_dispatchonrelease.yml(sinceCHANGELOG.mdis already onmainand won't push-trigger again)gh release createpublishes the asset