Self-closing tag ending as per doctype setting#85
Merged
Bloke merged 1 commit intotextpattern:mainfrom Nov 9, 2022
jools-r:main
Merged
Self-closing tag ending as per doctype setting#85Bloke merged 1 commit intotextpattern:mainfrom jools-r:main
Bloke merged 1 commit intotextpattern:mainfrom
jools-r:main
Conversation
Pleases the W3C validator. Self-closing tag ending acc. to doctype setting Pleases the W3C validator.
Bloke
approved these changes
Nov 9, 2022
| return ($labelStr && $label_position === 'before' ? $labelStr . $break : '') . | ||
| '<input type="radio"'. $classStr . ($attr ? ' ' . implode(' ', $attr) : '') . | ||
| ( $is_checked ? ' checked' . (($doctype === 'xhtml') ? '="checked"' : ''). ' />' : ' />') . | ||
| ( $is_checked ? ' checked' . (($doctype === 'xhtml') ? '="checked"' : '') : '') . (($doctype === 'xhtml') ? ' />' : '>') . |
Member
There was a problem hiding this comment.
Not sure about this line. I might be reading it wrong but there seems to be an additional : '') that's snuck in and I can't see the corresponding ternary ?. What am I missing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the self-closing tag ending according to HTML5 or XHTML doctype setting. Together with a similar patch for the core, this pleases the W3C validator.
Possible side effects: can produce a warm glow ;-)