Conversation
- AWSSDK.SQS / SimpleNotificationService / KeyManagementService / SecretsManager 4.0.100.3 -> 4.0.100.5 - OpenTelemetry (+ exporters/instrumentation) 1.16.0 -> 1.17.0 - Microsoft.Extensions.Caching.Memory 10.0.9 -> 10.0.10 - Microsoft.AspNetCore.TestHost 10.0.9 -> 10.0.10 - Microsoft.NET.Test.Sdk 18.7.0 -> 18.8.1 - OpenTelemetry.Exporter.InMemory 1.16.0 -> 1.17.0 PgpCore 7.2.0 -> 8.0.0 is held back: it is a major bump of the crypto layer (BouncyCastle transitivity has bitten before) and warrants a dedicated change.
Major bump of the OpenPGP layer. Source- and runtime-compatible for SquidStd's usage: SquidStd.Crypto builds unchanged and all 68 Crypto/PGP tests (generate/encrypt/decrypt/sign/verify round-trips) pass. BouncyCastle.Cryptography resolves to 2.6.2 as before (no transitive conflict).
feat(config): per-file plugin config (RegisterConfigFile) + dependency refresh
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| var name = string.IsNullOrWhiteSpace(configName) ? sectionName : configName; | ||
| var convention = container.Resolve<SquidStdConfig>().NamingConvention; | ||
| var path = Path.Combine(Path.GetFullPath(configDirectory), Path.HasExtension(name) ? name : $"{name}.yaml"); |
| { | ||
| using var root = new TempDirectory(); | ||
| using var external = new TempDirectory(); | ||
| File.WriteAllText(Path.Combine(external.Path, "sample.yaml"), "sample:\n Name: fromfile\n Count: 7\n"); |
|
|
||
| await bootstrap.StartAsync(); | ||
|
|
||
| Assert.True(File.Exists(Path.Combine(external.Path, "host.yaml"))); // generated despite the primary existing |
| container.Resolve<TestConfig>().Name = "persisted"; | ||
| manager.Save(); | ||
|
|
||
| Assert.True(File.Exists(Path.Combine(root.Path, "app.yaml"))); |
| manager.Save(); | ||
|
|
||
| Assert.True(File.Exists(Path.Combine(root.Path, "app.yaml"))); | ||
| var externalYaml = File.ReadAllText(Path.Combine(externalDir, "sample.yaml")); |
| { | ||
| using var root = new TempDirectory(); | ||
| using var external = new TempDirectory(); | ||
| File.WriteAllText(Path.Combine(root.Path, "app.yaml"), "app:\n Marker: keep\n"); |
|
|
||
| manager.EnsureFiles(); | ||
|
|
||
| Assert.Equal("app:\n Marker: keep\n", File.ReadAllText(Path.Combine(root.Path, "app.yaml"))); |
| manager.EnsureFiles(); | ||
|
|
||
| Assert.Equal("app:\n Marker: keep\n", File.ReadAllText(Path.Combine(root.Path, "app.yaml"))); | ||
| Assert.True(File.Exists(Path.Combine(externalDir, "sample.yaml"))); |
| using var external = new TempDirectory(); | ||
| var (manager, container, externalDir) = Build(root, external); | ||
|
|
||
| File.WriteAllText(Path.Combine(externalDir, "sample.yaml"), "sample:\n Name: reloaded\n Count: 9\n"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release cut for the multi-file plugin config feature (minor).
RegisterConfigFile<T>for per-file plugin configConfigManagerServicespans external files in Save/Load; newEnsureFiles()No breaking changes. 1378 non-integration tests green; CI (build-test + CodeQL) green on the develop PR.