Update export to video implementation#2
Open
tginart wants to merge 7 commits into
Open
Conversation
Co-authored-by: tginart <tginart@gmail.com>
|
Cursor Agent can help with this pull request. Just |
tginart
marked this pull request as ready for review
September 6, 2025 06:24
Co-authored-by: tginart <tginart@gmail.com>
Co-authored-by: tginart <tginart@gmail.com>
Co-authored-by: tginart <tginart@gmail.com>
Co-authored-by: tginart <tginart@gmail.com>
Co-authored-by: tginart <tginart@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a cautious multi-pass video export pipeline that renders segments and tracks separately before final composition, falling back to the original monolithic approach on failure.
The monolithic FFmpeg
-filter_complexcan become extremely complex and difficult to debug or scale for intricate compositions. This multi-pass approach breaks down the composition into smaller, more manageable FFmpeg commands, rendering individual segments and then tracks with alpha channels, before a final overlay. This improves robustness and provides a fallback mechanism to the proven monolithic path if the new pipeline encounters issues.