chore(deps): migrate to sypl v2 - #12
Merged
Merged
Conversation
Rewrite all sypl imports to the `/v2` module path and update go.mod to require `github.com/thalesfsp/sypl/v2 v2.0.0` directly, dropping the v1 direct dependency (v1 now lingers only as an indirect via concurrentloop). dal uses only sypl's core surface (sypl.New, output.Console, level, processor, formatter, fields) — no ElasticSearch outputs, no removed APIs, and no numeric level literals — so this is a pure import-path migration. dal's own elasticsearch/ storage adapter (go-elasticsearch) is unrelated to sypl and untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrates
dal(modulegithub.com/thalesfsp/dal/v2) from sypl v1 to sypl v2./v2module path (basesypl, plusfields,formatter,level,output,processor).go.mod: requiresgithub.com/thalesfsp/sypl/v2 v2.0.0directly; drops the v1 direct dependency. sypl v1 now appears only as an// indirectentry, pulled transitively bygithub.com/thalesfsp/concurrentloop(which has not migrated yet).Scope / why it's a clean mechanical migration
dal uses only sypl's core surface —
sypl.New,output.Console,level.*,processor.*,formatter.Text,fields.Fields. It touches none of v2's three breaking changes:output.ElasticSearch*/ sypl'selasticsearchpackage) → the newes/v2submodule is not needed. dal's ownelasticsearch/package is its storage adapter overgo-elasticsearchand is unrelated to sypl.FromInt→ unaffected by the Warn/Info reordering.SetName,GetProcessor,SetContent,SetLevel,AnyMaxLevel,SetBuiltinLogger,debug.Match*).Verification (local, macOS)
go build ./...andgo vet ./...: clean.go test -short -race ./...(ENVIRONMENT=testing, the default Maketesttarget): all packages pass exceptfile'sTestFile_CreateIfNotExistDoesNotLeakFDs, which is a pre-existing macOS-only failure — it reads/proc/self/fd(Linux procfs, absent on Darwin). Verified identical on unmodifiedorigin/main; it passes on Linux CI. Not a regression from this change.ENVIRONMENT=testingand were not run locally (no databases stood up). CI exercises them.Downstream impact
Tagging a new
dalrelease after this merges lets downstream consumers (e.g.etler, which flaggeddalas its remaining v1 source) evictsyplv1 from their direct module graphs.