Interactive affordance vocabulary + Info-pane header & world-switch polish - #82
Merged
Conversation
…ver) Closes part of #78.
First tab sits flush with the content edge; each tab gets horizontal padding so the underline runs wider than the label. PaneTabs accepts a `class` pass-through; the source picker uses `pane-tabs--modal` for the gap above its form. Part of #78.
Pane gains a `headerSlot` that replaces the default title bar; the close button is extracted to a shared <PaneCloseButton>. Info drops its "Info" title row and renders the Overview/Readme tabs as the header, reclaiming a row of vertical space. Also resets the subtab to Overview on world switch (InfoPane stays mounted, so its subtab would otherwise persist).
On each world commit (keyed on CURRENT_SOURCE): reset the picker selection so the right sidebar closes and the tree highlight clears (it previously carried a stale node into the new world), and expand the left sidebar alongside the existing open-to-Info reset. Also drops the activity bar's top padding so the first icon sits flush.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78.
#78 — interactive elements now read as interactive
A token-driven affordance vocabulary, applied through the existing
styles/kit (no bespoke per-component styles):.link(prose/markdown: accent + always underlined, AA-safe) and.link--chrome(repo URL / SHA: accent + underline on hover). The three hand-rolled baselines (.almanac-meta a,.almanac-sha-link,.info-markdown a) collapse onto these; the shared underline color is the new--cc-accent-light-bordertoken..pane-tabbecomes an underline strip; the duplicate.modal-tabsstyling is deleted and the source picker reusesPaneTabs. One tab component, compatible with Reorganize Settings pane onto PaneTabs subtabs #69's Settings subtabs.:focus-visiblering (styles/focus.css) covering every button, link, tab, and row. Closes the keyboard gap (coordinates with Accessibility audit #79)..pane-tabrest from--cc-text-faintto--cc-text-muted(6.08:1). Links land at 10:1+, the active-tab underline at 7:1.Beyond #78 — Info-pane header & world-switch UX (requested in review)
Grouped in their own commits so the affordance work stays separable:
Panegains aheaderSlot; the close×is extracted to a shared<PaneCloseButton>. Info drops its "Info" title row and renders the Overview/Readme tabs as the header itself, reclaiming a row of vertical space. Tabs sit flush-left with internal label padding.CURRENT_SOURCE, so in-place refreshes don't trigger them): reset the picker → right sidebar closes + tree highlight clears (it previously carried a stale node into the new world); expand the left sidebar; reset the Info subtab to Overview.Verification
Verified visually in the running app (
just dev) with mouse + keyboard across every audited surface, plusjust lintandjust test(2373 passing).