Parse scoped inline-flag groups instead of crashing - #60
Merged
Conversation
(?i:abc) and friends ((?i-s:...), (?-i:...), (?ims:...)) matched no
group-opening rule, so the lexer fell through to '(' as a capturing
group and then treated the trailing '?' as a quantifier with nothing
to bind, raising "IndexError: pop from empty list" in get_parse_tree
before any checker could run.
Add a tokenizer rule for scoped inline flags. It is placed after the
plain (?:...) rule so ordinary non-capturing groups are unaffected, and
it uses a dedicated Other.Open.NonCapturingFlags type rather than
Other.Open.NonCapturing: a flag-scoped group is not interchangeable with
a bare (?:...) group, so keeping it a distinct type stops checks such as
redundant-group from suggesting a removal that would silently drop the
flags.
Add the flag-scoped forms to SAMPLE_PATTERNS so the existing
reconstruct round-trip test covers both parsing and byte-exact output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(?i:abc) and friends ((?i-s:...), (?-i:...), (?ims:...)) matched no group-opening rule, so the lexer fell through to '(' as a capturing group and then treated the trailing '?' as a quantifier with nothing to bind, raising "IndexError: pop from empty list" in get_parse_tree before any checker could run.
Add a tokenizer rule for scoped inline flags. It is placed after the plain (?:...) rule so ordinary non-capturing groups are unaffected, and it uses a dedicated Other.Open.NonCapturingFlags type rather than Other.Open.NonCapturing: a flag-scoped group is not interchangeable with a bare (?:...) group, so keeping it a distinct type stops checks such as redundant-group from suggesting a removal that would silently drop the flags.
Add the flag-scoped forms to SAMPLE_PATTERNS so the existing reconstruct round-trip test covers both parsing and byte-exact output.