Skip to content

fix: update bearer token - #26

Merged
karashiiro merged 2 commits into
the-convocation:mainfrom
Owen3H:auth-update
Jul 13, 2023
Merged

fix: update bearer token#26
karashiiro merged 2 commits into
the-convocation:mainfrom
Owen3H:auth-update

Conversation

@Owen3H

@Owen3H Owen3H commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

Heyo, me again 👋🏼

  • removed both tokens in favour of new, updated one used by nitter.
  • implemented cleaner useGuestAuth method used by both constructor and logout.
  • created a new test to ensure tweets are fetched without logging in.
  • running latest tweet test now uses regular scraper instead of authSearchScraper.

Note:
Nitter also changed some features and graphql endpoints, but I'm not familiar with them so they were not included.
See this commit

- removed both tokens in favour of new, updated one used by nitter.
- updated latest tweet test to remove auth.
- created a new test to ensure tweets are fetched without logging in.
- implemented cleaner `useGuestAuth` method used by both constructor and `login`

Note:
Nitter also changed some features and graphql endpoints, but I'm not familiar with them so they were not included. see [this commit](zedeus/nitter@d1f8044#diff-5191c99e8da841954d23cae0097143d48f54b50737f8ef7b8b7ef2fabdd2dcd6)
@Owen3H

Owen3H commented Jul 11, 2023

Copy link
Copy Markdown
Contributor Author

Just to clarify on the tests:

All of them pass with flying colours, however I only replaced 2 with a regular Scraper.
To see if all of the others pass without logging in, they will also need authSearchScraper replacing.

@karashiiro
karashiiro merged commit fdf8647 into the-convocation:main Jul 13, 2023
@karashiiro

karashiiro commented Jul 13, 2023

Copy link
Copy Markdown
Collaborator

I replaced all the non-search/auth tests with regular scrapers and they worked perfectly (#27), thanks! I also tried replacing the search test scraper with a regular one for thoroughness, but that didn't work (as expected).

@Owen3H
Owen3H deleted the auth-update branch July 17, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants