fix some Tweet properties defaulting to undefined. - #31
Merged
Conversation
The following properties on the `Tweet` interface are now `false` as default. This most likely fixes any method that relies on checking these. - isQuoted - isRetweet - isReply - isPin - sensitiveContent Tweet tests have been updated accordingly.
Collaborator
|
The reason I left those as undefined was because I thought there was some semantic difference between the reply flag being undefined versus false; I don't remember any specific cases though, so I may be imagining things. Looks good, merging. |
Contributor
Author
|
It's all good, just confused me when I was getting no results. Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following properties on the
Tweetinterface are nowfalseas default.This most likely fixes any methods that caused issues as a result of checking any of these.
isQuotedisRetweetisReplyisPinsensitiveContentTweet tests have been updated accordingly.