Verify firmware build in CI, not just unit tests - #5
Merged
Conversation
Renames the workflow to ci.yml and turns it into a matrix job: native still runs the unit tests, and a new kb2040 leg runs `pio run -e kb2040` so a build-breaking change (bad pin, missing include, etc.) fails CI even if it doesn't trip a unit test. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Branch protection requires a status check literally named "native-tests" — a matrix job would report as "build (native)" and never satisfy that rule. Two explicit jobs keep the existing required check working with no ruleset changes needed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/test.ymltoci.ymland expands it to a matrix job (native,kb2040) instead of a single native-only job.nativestill runspio test -e native; the newkb2040leg runspio run -e kb2040so a build-breaking change (bad pin reference, missing include, etc.) fails CI even when it doesn't trip a unit test.Test plan
pio test -e nativepasses locallypio run -e kb2040builds and links locally🤖 Generated with Claude Code