Pin streamlit to a tested range instead of an unbounded lower bound - #99
Merged
tishachawla-jg merged 1 commit intoSep 4, 2026
Merged
Conversation
pyproject.toml declared streamlit>=1.30 with no upper bound, and CI resolves whatever version pip picks that day. That let a Streamlit-internal regression through with zero warning (the old README demo gif captured a crash from ButtonMixin.page_link() that doesn't reproduce on 1.63.0, since fixed upstream). Pinned to >=1.38,<2 -- roughly when the st.navigation/st.Page multipage API used in src/tokenops/ui/app.py and examples/ui/app.py stabilized. Closes theagentplane#84 Signed-off-by: SurajPatelPro <soorajit@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
pyproject.tomldeclaredstreamlit>=1.30with no upper bound, and CI doesn't pin an exact version either —pip installresolves whateverstreamlitrelease is current that day. This isn't hypothetical: the README hero gif used to show a Streamlit-internal crash (TypeError: ButtonMixin.page_link() got an unexpected keyword argument 'query_params') that doesn't reproduce on today's latest (1.63.0) — a version-specific regression in whatever release was live at the time, since fixed upstream. An unbounded dependency let that through with zero warning.Closes #84
What changed
pyproject.toml—streamlit>=1.30→streamlit>=1.38,<2. The floor is roughly when thest.navigation/st.Pagemultipage API used insrc/tokenops/ui/app.pyandexamples/ui/app.pystabilized.CHANGELOG.md— entry under[Unreleased].How it was verified
pip install -e ".[dev,examples]"resolvesstreamlit==1.63.0, within the new range.make lint(ruff check, ruff format --check, sync-skills --check, mypy) — clean.make test(pytest -q) — 222 passed, 2 skipped, 11 deselected (e2e/live, excluded by default markers). 3 pre-existing failures intests/test_a2a_health.py(missingpytest-asyncioplugin) reproduce identically on unmodifiedmain— unrelated to this change, confirmed viagit stash.