fix(web): bake API URL into proxy rewrites - #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
FACILITY_API_URLinto Next.js rewrite rules.infra/build-images.shfor AWS web builds.http://api:4400URL through the documented Docker Compose build.Why
The production web image compiled its same-origin
/api/*proxy with the localhost fallback. ECS supplied the public API URL only at runtime, so/api/auth/loginattempted to reach127.0.0.1:4400and returned 500 even though the API service was healthy.Verification
pnpm verifypasses locallylinux/amd64image and confirmed itsroutes-manifest.jsoncontainshttps://api.facility.tam-os.com/:path*; rolled ECS web to task definition revision 2 and verified/api/auth/loginreturns 302 to GitHub; builtfacility-webthrough Docker Compose and confirmed its manifest containshttp://api:4400/:path*)pnpm verifywas run withCOMPOSE_ENV_FILES=.env.exampleso Docker Compose did not load deployment credentials from the local.env.