Adapt page analytics layout and links - #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Removing the Pages card from document-scoped analytics changed CSS Grid auto-placement, leaving the remaining cards visually unbalanced. The Flags card also stretched too far on wide screens and wasted an available grid cell at the intermediate breakpoint. Separately, the header displayed the current hostname but always linked to the site root even though the resolved document route was already available.
Impact
Page analytics now uses the available space more intentionally across desktop, tablet, and mobile widths. Editors can also open the exact page they are reviewing directly from its analytics header.
Verification
corepack pnpm buildcorepack pnpm test -- src/analytics/analytics-components.test.ts(105 tests passed)git diff --check