Bump MessagePack and Microsoft.OpenApi to match Umbraco 18.1.0 - #47
Merged
Conversation
Umbraco 18.1.0 now pulls MessagePack 3.1.8 and Microsoft.OpenApi 2.11.0 transitively. The project pinned 3.1.7 and 2.7.5, so restore under the floating 17.* and 18.* CI legs reported an NU1605 package downgrade, which TreatWarningsAsErrors turns into a build failure. Raise the pins to 3.1.8 and 2.11.0 (still floors) so restore is clean. Verified: restore passes for UmbracoVersion 18.*, 17.*, and 17.1.0, and the project builds against 18.* with no warnings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises two pinned package versions so the .NET restore stays clean against the current floating Umbraco releases:
MessagePack3.1.7->3.1.8Microsoft.OpenApi2.7.5->2.11.0Why
The CI matrix builds against floating Umbraco versions (
17.*,18.*). The newly published Umbraco 18.1.0 pullsMessagePack 3.1.8andMicrosoft.OpenApi 2.11.0transitively, which are higher than the pinned3.1.7/2.7.5. NuGet reports anNU1605package downgrade, andTreatWarningsAsErrorsturns it into a restore failure on the.NET (Umbraco 17.*)and.NET (Umbraco 18.*)legs. The pinned17.1.0leg predates the bump and still passed.The pins were originally floors ("keep at or above what Umbraco requires"); this just moves the floors up to where Umbraco's graph now sits.
Verification
Local
dotnet restoreis clean forUmbracoVersion=18.*,17.*, and17.1.0, anddotnet buildagainst18.*succeeds with no warnings.Note
This is independent of the docs landing-page work in #46. It surfaced there only because that PR triggered a CI run after Umbraco 18.1.0 shipped; the same failure would occur on
main.🤖 Generated with Claude Code