Add package validation workflow - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainWhy
The package did not have automated validation for its client or supported Umbraco compatibility matrix. This workflow makes regressions visible before changes reach
main.Impact
Contributors will get separate client and .NET validation results. The .NET matrix reports compatibility failures independently for both supported Umbraco majors.
Verification
corepack pnpm install --frozen-lockfilecorepack pnpm test— 99 tests passedcorepack pnpm builddotnet test tests/TheBuilder.WebAnalytics.Tests/TheBuilder.WebAnalytics.Tests.csproj -p:UmbracoVersion=17.1.0— 118 tests passeddotnet build samples/TheBuilder.WebAnalytics.Example/TheBuilder.WebAnalytics.Example.csproj -p:UmbracoVersion=17.1.0dotnet test tests/TheBuilder.WebAnalytics.Tests/TheBuilder.WebAnalytics.Tests.csproj -p:UmbracoVersion=18.0.0— 118 tests passeddotnet build samples/TheBuilder.WebAnalytics.Example/TheBuilder.WebAnalytics.Example.csproj -p:UmbracoVersion=18.0.0Existing transitive NuGet vulnerability warnings remain unchanged.