Customizing username field with Credential Password plugin

[Gustavo-DMS]

Reading through the docs I could not find a way to customize the "username" field name. Is there a way to do this that I am missing or it currently not supported?

I have tried configuring using WithPluginSchema, which seems to work on sign In but fails on sign Up saying I don't have the column username.

[thecodearcher]

@Gustavo-DMS Thanks for flagging this; it was actually a bug.

WithPluginSchema(...) could remap username lookups, but sign-up could still try to write username, which caused the missing column error when using a custom column name. This is now fixed in 0.1.3

Also added a convenient wrapper so you can do this instead of using WithPluginSchema directly:

schema := limen.NewDefaultSchemaConfig(
    credentialpassword.WithUsernameField("handle"),
)

[Gustavo-DMS]

Thank for the quick response!

When trying the fix I came across this error:

# github.com/thecodearcher/limen/plugins/credential-password
/go/pkg/mod/github.com/thecodearcher/limen/plugins/credential-password@v0.1.3/plugin.go:93:25: cannot use CredentialPasswordUserSchemaUsernameField (constant "username" of string type limen.SchemaField) as string value in argument to limen.WithSchemaField

When looking around it the code the following change to plugin.go seemed to fix the problem in my tests, I can open a PR if you want but for a one line change I guess it would be easier for you to just change it.

func (p *credentialPasswordPlugin) GetSchemas(schema *limen.SchemaConfig) []limen.SchemaIntrospector {
	if !p.config.enableUsername {
		return []limen.SchemaIntrospector{}
	}

	userWithUsername := &CredentialPasswordUserSchema{
		UserSchema: schema.User,
	}
	extension := limen.NewSchemaDefinitionForExtension(
		limen.CoreSchemaUsers,
		userWithUsername,
- 		limen.WithSchemaField(CredentialPasswordUserSchemaUsernameField, limen.ColumnTypeString, limen.WithNullable(true)),
+ 		limen.WithSchemaField(string(CredentialPasswordUserSchemaUsernameField), limen.ColumnTypeString, limen.WithNullable(true)),
		limen.WithSchemaIndex("idx_users_username", []limen.SchemaField{CredentialPasswordUserSchemaUsernameField}),
	)

	return []limen.SchemaIntrospector{extension}
}

[thecodearcher]

Oh, this has been fixed in the latest release now.