Added a module for the interaction map#839
Closed
Pupsiso wants to merge 3 commits intothedevs-network:mainfrom
Closed
Added a module for the interaction map#839Pupsiso wants to merge 3 commits intothedevs-network:mainfrom
Pupsiso wants to merge 3 commits intothedevs-network:mainfrom
Conversation
Author
|
Let me know if anything needs to be changed. |
Member
|
Did you use generative AI to write this code by any chance? I see some unnecessary parts that could be removed |
Author
|
@poeti8 Hi, yes I did use AI for some parts. I removed the unnecessary "createZoomButton" since it's no longer used – it's now created in stats.hbs. |
Closed
Member
|
I really don't like the over-engineered code written with AI, especially all the |
Author
|
Hi, this refers to the mapInteractions object internally, so that we don't have to write the full name. We use this.isMobile instead of mapInteractions.isMobile. AI is used solely for correctly computing the matrix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a function that enables map interaction, allowing panning and zooming. #831