Skip to content

Added a module for the interaction map#839

Closed
Pupsiso wants to merge 3 commits intothedevs-network:mainfrom
Pupsiso:feature/interaction-map
Closed

Added a module for the interaction map#839
Pupsiso wants to merge 3 commits intothedevs-network:mainfrom
Pupsiso:feature/interaction-map

Conversation

@Pupsiso
Copy link

@Pupsiso Pupsiso commented Mar 11, 2025

Added a function that enables map interaction, allowing panning and zooming. #831

@Pupsiso
Copy link
Author

Pupsiso commented Mar 11, 2025

Let me know if anything needs to be changed.

@poeti8
Copy link
Member

poeti8 commented Mar 30, 2025

Did you use generative AI to write this code by any chance? I see some unnecessary parts that could be removed

@Pupsiso
Copy link
Author

Pupsiso commented Mar 30, 2025

@poeti8 Hi, yes I did use AI for some parts. I removed the unnecessary "createZoomButton" since it's no longer used – it's now created in stats.hbs.

@trgwii trgwii mentioned this pull request Apr 2, 2025
@poeti8
Copy link
Member

poeti8 commented Apr 3, 2025

I really don't like the over-engineered code written with AI, especially all the thises used. I'll close this one, feel free to open another pull request if you wrote all the code yourself, or at least read it before submitting.

@poeti8 poeti8 closed this Apr 3, 2025
@Pupsiso
Copy link
Author

Pupsiso commented Apr 3, 2025

Hi, this refers to the mapInteractions object internally, so that we don't have to write the full name. We use this.isMobile instead of mapInteractions.isMobile. AI is used solely for correctly computing the matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments