Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Oct 26, 2025

No description provided.

@evgeni
Copy link
Member

evgeni commented Oct 27, 2025

this will break at least rubygem-opennebula and needs a tiny gemfix there.

@github-actions github-actions bot force-pushed the bump_rpm/rubygem-nokogiri branch 5 times, most recently from 8ffe2f3 to 1a1c557 Compare November 5, 2025 04:13
@github-actions github-actions bot force-pushed the bump_rpm/rubygem-nokogiri branch 2 times, most recently from d6852a6 to 73bbdeb Compare November 12, 2025 04:13
@github-actions github-actions bot force-pushed the bump_rpm/rubygem-nokogiri branch 2 times, most recently from e0fe7f7 to 8ba75d2 Compare November 19, 2025 04:12
@github-actions github-actions bot force-pushed the bump_rpm/rubygem-nokogiri branch 3 times, most recently from f966bba to 5b9352d Compare November 26, 2025 04:14
@github-actions github-actions bot force-pushed the bump_rpm/rubygem-nokogiri branch 3 times, most recently from f82d855 to ffa094b Compare December 7, 2025 04:20
@github-actions github-actions bot force-pushed the bump_rpm/rubygem-nokogiri branch 4 times, most recently from eb81971 to ed22c14 Compare December 14, 2025 04:22
@github-actions github-actions bot force-pushed the bump_rpm/rubygem-nokogiri branch from ed22c14 to 628c7ee Compare December 17, 2025 04:18
@ogajduse
Copy link
Member

this will break at least rubygem-opennebula and needs a tiny gemfix there.

@evgeni Could you give me a bit more context about this? What is the fix we need to do?

@evgeni
Copy link
Member

evgeni commented Dec 17, 2025

opennebula wrongly pins nokogiri to < 1.16:
https://github.com/OpenNebula/one/blob/3582f79c2cf7c890a8b7cc46565f4a5fa769938d/share/rubygems/generate#L84

When we update to 1.16+, we'll have to fix up the deps in our rubygem-opennebula package like we do every now and then with others. Example:

%gemspec_remove_dep -g thor ['>= 1.0.1', '< 1.3']
%gemspec_add_dep -g thor ['>= 1.0.1', '< 2.0']

So in this case you'd have to do something like:

%gemspec_remove_dep -g nokogiri ['< 1.16'] 
%gemspec_add_dep -g nokogiri

@ekohl
Copy link
Member

ekohl commented Dec 17, 2025

I don't see an open issue/PR in that repo to improve that. @ogajduse could you open one and link to it in a comment when applying the hack that @evgeni suggested (which is the correct short term fix).

@evgeni
Copy link
Member

evgeni commented Dec 17, 2025

For reference, the bad pin was introduced because of OpenNebula/one#6512

@ekohl ekohl force-pushed the bump_rpm/rubygem-nokogiri branch from 5834195 to 4273fac Compare December 19, 2025 15:17
@ekohl ekohl force-pushed the bump_rpm/rubygem-nokogiri branch from 4273fac to e82670e Compare December 19, 2025 15:20
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased and squashed the commits, also making you the owner. I've confirmed this also allows building on EL 10 so I'm happy to see this.

@ekohl ekohl enabled auto-merge (rebase) December 19, 2025 15:21
@ekohl ekohl merged commit 5d06a30 into rpm/develop Dec 19, 2025
3 checks passed
@ekohl ekohl deleted the bump_rpm/rubygem-nokogiri branch December 19, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants