Add webhooks feature - #694
Merged
Merged
Conversation
8 tasks
Contributor
Author
Huh, but the provide should be there https://github.com/theforeman/foreman-packaging/blob/rpm/develop/packages/plugins/rubygem-hammer_cli_foreman_webhooks/rubygem-hammer_cli_foreman_webhooks.spec#L22 Edit: Ohh, it's on EL10 |
Member
|
Yeah, it's using a copr of mine, as upstream Foreman doesn't have EL10 yet. I triggered a build of that hammer plugin and kicked off tests. |
evgeni
approved these changes
Jul 27, 2026
Member
|
@adamruzicka does anyone from your team wants to further review/test this, or shall we merge it? |
Contributor
Author
|
I'd vote for merging. |
Member
|
this is what I call democracy ;) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
It was supported by the old installer, but isn't supported by foremanctl yet.
What are the changes introduced in this pull request?
Add webhooks feature. So far it only deals with the foreman_webhooks plugin and it's hammer counterpart. Shellhooks is intentionally left out of scope of this PR.
How to test this pull request
Steps to reproduce:
At a bare minimum:
./foremanctl features | grep -i webhooksTo test fully:
./foremanctl deploy --add-feature webhooksChecklist
Requires