Skip to content

Add webhooks feature - #694

Merged
evgeni merged 1 commit into
theforeman:masterfrom
adamruzicka:webhooks
Jul 27, 2026
Merged

Add webhooks feature#694
evgeni merged 1 commit into
theforeman:masterfrom
adamruzicka:webhooks

Conversation

@adamruzicka

Copy link
Copy Markdown
Contributor

Why are you introducing these changes? (Problem description, related links)

It was supported by the old installer, but isn't supported by foremanctl yet.

What are the changes introduced in this pull request?

Add webhooks feature. So far it only deals with the foreman_webhooks plugin and it's hammer counterpart. Shellhooks is intentionally left out of scope of this PR.

How to test this pull request

Steps to reproduce:

At a bare minimum: ./foremanctl features | grep -i webhooks

To test fully:

  1. ./foremanctl deploy --add-feature webhooks
  2. Wait for it to deploy
  3. Create a webhook that fires on domain creation
  4. Create a domain
  5. Observe the webhook being delivered

Checklist

  • Tests added/updated (if applicable)
  • Documentation updated (if applicable)

Requires

@adamruzicka

adamruzicka commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author
  • No package hammer-cli-plugin-foreman_webhooks available.

Huh, but the provide should be there https://github.com/theforeman/foreman-packaging/blob/rpm/develop/packages/plugins/rubygem-hammer_cli_foreman_webhooks/rubygem-hammer_cli_foreman_webhooks.spec#L22

Edit: Ohh, it's on EL10

@evgeni

evgeni commented Jul 27, 2026

Copy link
Copy Markdown
Member

Yeah, it's using a copr of mine, as upstream Foreman doesn't have EL10 yet. I triggered a build of that hammer plugin and kicked off tests.

@evgeni

evgeni commented Jul 27, 2026

Copy link
Copy Markdown
Member

@adamruzicka does anyone from your team wants to further review/test this, or shall we merge it?

@adamruzicka

Copy link
Copy Markdown
Contributor Author

I'd vote for merging.

@evgeni
evgeni merged commit fe98939 into theforeman:master Jul 27, 2026
29 of 42 checks passed
@evgeni

evgeni commented Jul 27, 2026

Copy link
Copy Markdown
Member

this is what I call democracy ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants