🐛 remove banned triple slash#1121
Merged
Merged
Conversation
commit: |
cowboyd
force-pushed
the
fix-banned-triple-slash
branch
from
4066d9e to
0b1513f
Compare
JSR does not allow triple slashes, and so this was causing publication to fail. This removes it since it does not actually add anything of value. Furthermore, it adds npm and jsr dry runs after tests run. Finally, it adds these preflight checks to the publication workflow as a precondition for _both_ npm _and_ jsr. That way, we won't publish either unless both are expected to work.
cowboyd
force-pushed
the
fix-banned-triple-slash
branch
from
0b1513f to
346be14
Compare
taras
approved these changes
Feb 19, 2026
taras
reviewed
Feb 19, 2026
| node-version: 24 | ||
|
|
||
| - name: Build NPM | ||
| run: deno task build:npm 4.0.0-verify.0 |
Member
There was a problem hiding this comment.
Why is there a hardcoded version here?
taras
reviewed
Feb 19, 2026
| node-version: 24 | ||
|
|
||
| - name: Build NPM | ||
| run: deno task build:npm 4.0.0-verify.0 |
Member
There was a problem hiding this comment.
Oh, i see because you need a version number. It might be worth adding a comment here to explain.
Member
Author
There was a problem hiding this comment.
Yeah, this is just a total dummy number. It could be 12.1000.675-verify.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
jsr.io does not allow triple slashes.
Approach
This remove it since it can be set by the consuming library. This also adds validation checks after tests have successfully run to see if publication would succeed on both npm and jsr.
This also adds these same pre-flight checks to the actual publication workflow. It ensures that both JSR and NPM will work before attempting either. That way we don't end up in a situation where we have the package on one registry and not another.