🐛 Bound Windows process shutdown - #231
Closed
taras wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Windows teardown currently waits for stdout and stderr EOF before checking whether it should run
taskkill /T /F. When a process or descendant keeps an inherited output handle open, that wait never completes, the force-kill fallback is unreachable, and scope teardown hangs.This is the Windows-specific follow-up to #228 and is intentionally separate from the
Process.exited()API work in #230.Approach
taskkill /T /Fwhen the grace period expires, then await final stdout and stderr closure.Task.halt()to finish.@effectionx/processfrom 0.8.1 to 0.8.2.Validation
pnpm checkpnpm buildpnpm lintpnpm fmt:checkpnpm syncpnpm test:node(34 passed)pnpm test process(36 passed locally; Windows-only regression skipped on macOS)pnpm test(382 passed, 6 skipped)