Add kid to JWT protected header so tokens match JWKS - #375
Conversation
Include kid (JWKS.keys[0].kid) in SignJWT().setProtectedHeader() for access_token and id_token so clients performing JWKS-based signature verification can find the correct public key. Fixes thefrontside#374
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughJWT signing now includes ChangesJWT key ID headers
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Package Changes Through 9050d7dThere are 1 changes which include @simulacrum/auth0-simulator with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
jbolda
left a comment
There was a problem hiding this comment.
Makes sense to me. Thanks, appreciate it!
commit: |
Include kid (JWKS.keys[0].kid) in SignJWT().setProtectedHeader() for access_token and id_token so clients performing JWKS-based signature verification can find the correct public key.
Fixes #374
Summary by CodeRabbit