fix(cargo): align crate repository metadata with workspace URL - #1795
Conversation
Thirty-three crate manifests set `repository` to `https://github.com/theinterfold/interfold/crates/<name>`, which omits `/tree/main` and returns 404. The root manifest already defines the correct URL under `[workspace.package]`, and twelve crates already inherit it, so these are outliers rather than the convention. Point every workspace member at the inherited value. Also add the missing field to `e3-dashboard` and drop the duplicated literal in `interfoldup`. `examples/CRISP` is an excluded, independent workspace root and keeps its own literal, since it cannot inherit. The crates are not published yet, but `releases.yml` publishes with `publish = true`, so the broken URL would ship on the first release. Refs theinterfold#1794 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
@Toby1009 is attempting to deploy a commit to the Gnosis Guild Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (35)
📝 WalkthroughWalkthroughThe pull request updates 35 crate manifests. Each crate now inherits repository metadata from the workspace. The dashboard manifest now includes the inherited repository field. ChangesRepository metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to This updates crate repository metadata to the workspace URL without changing code or runtime behavior; the reported manifest and project checks pass, so no actionable merge-blocking risk remains. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
The job log: The cause is in This is already fixed in #1774, which switches the step to For reference, the other two PRs from this same audit (#1796, #1797) are fully green — they do not |
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
What
Thirty-three crate manifests set
repositorytohttps://github.com/theinterfold/interfold/crates/<name>,which omits
/tree/mainand returns 404. This points every workspace member at the inherited[workspace.package]value instead, which already holds the correct URL and which twelve cratesalready use.
Also folded in two adjacent gaps found during review:
e3-dashboardhad norepositoryfield at all,and
interfoldupduplicated the root URL literally rather than inheriting it.examples/CRISPkeepsits own literal, since it is in the root workspace's
excludelist and is its own[workspace]root,so it cannot inherit.
The crates are not on crates.io yet, but
.github/workflows/releases.ymlpublishes withpublish = true, so the broken URL would ship on the first release.Closes part of #1794 (section 1).
Checklist
verification is at the manifest layer:
cargo metadata --no-deps --format-version 1(all 45 packages now reporthttps://github.com/theinterfold/interfold, zero missing — was 44 correct + 1 missing before),cargo verify-project({"success":"true"}),pnpm check:license,pnpm check:docs.Confirmed no code reads
CARGO_PKG_REPOSITORYand no workflow or script reads the manifestrepositoryfield.changes;
repositoryis inert Cargo metadata.agent/INVARIANTS.md. Nothing in the meta-invariant list(committee ordering, thresholds, proof multiplicity, hashing, signatures, witness shape, event
identity, replay) is touched.
Summary by CodeRabbit