Skip to content

fix(cargo): align crate repository metadata with workspace URL - #1795

Merged
ctrlc03 merged 1 commit into
theinterfold:mainfrom
Toby1009:fix/cargo-repository-metadata
Aug 13, 2026
Merged

fix(cargo): align crate repository metadata with workspace URL#1795
ctrlc03 merged 1 commit into
theinterfold:mainfrom
Toby1009:fix/cargo-repository-metadata

Conversation

@Toby1009

@Toby1009 Toby1009 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What

Thirty-three crate manifests set repository to https://github.com/theinterfold/interfold/crates/<name>,
which omits /tree/main and returns 404. This points every workspace member at the inherited
[workspace.package] value instead, which already holds the correct URL and which twelve crates
already use.

Also folded in two adjacent gaps found during review: e3-dashboard had no repository field at all,
and interfoldup duplicated the root URL literally rather than inheriting it. examples/CRISP keeps
its own literal, since it is in the root workspace's exclude list and is its own [workspace] root,
so it cannot inherit.

The crates are not on crates.io yet, but .github/workflows/releases.yml publishes with
publish = true, so the broken URL would ship on the first release.

Closes part of #1794 (section 1).

Checklist

  • Verified at the smallest covering scope — this is manifest metadata with no code path, so
    verification is at the manifest layer:
    cargo metadata --no-deps --format-version 1 (all 45 packages now report
    https://github.com/theinterfold/interfold, zero missing — was 44 correct + 1 missing before),
    cargo verify-project ({"success":"true"}), pnpm check:license, pnpm check:docs.
    Confirmed no code reads CARGO_PKG_REPOSITORY and no workflow or script reads the manifest
    repository field.
  • Harness docs — not applicable. No contract, circuit, actor routing, CLI behavior, or formula
    changes; repository is inert Cargo metadata.
  • Invariants — checked against agent/INVARIANTS.md. Nothing in the meta-invariant list
    (committee ordering, thresholds, proof multiplicity, hashing, signatures, witness shape, event
    identity, replay) is touched.
  • Known bugs table — not applicable. No protocol concern fixed or introduced.
  • Breaking? — no. Metadata only; no API, ABI, or behavior change.

Summary by CodeRabbit

  • Chores
    • Standardized repository metadata across packages by inheriting the shared workspace repository configuration.
    • Removed package-specific repository URLs, improving consistency and simplifying future metadata updates.

Thirty-three crate manifests set `repository` to
`https://github.com/theinterfold/interfold/crates/<name>`, which omits
`/tree/main` and returns 404. The root manifest already defines the
correct URL under `[workspace.package]`, and twelve crates already
inherit it, so these are outliers rather than the convention.

Point every workspace member at the inherited value. Also add the
missing field to `e3-dashboard` and drop the duplicated literal in
`interfoldup`. `examples/CRISP` is an excluded, independent workspace
root and keeps its own literal, since it cannot inherit.

The crates are not published yet, but `releases.yml` publishes with
`publish = true`, so the broken URL would ship on the first release.

Refs theinterfold#1794

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

@Toby1009 is attempting to deploy a commit to the Gnosis Guild Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 47d0b46a-be2a-4e97-bba2-d03f5c0813b4

📥 Commits

Reviewing files that changed from the base of the PR and between 835c893 and d8f6003.

📒 Files selected for processing (35)
  • crates/aggregator/Cargo.toml
  • crates/bfv-client/Cargo.toml
  • crates/ciphernode-builder/Cargo.toml
  • crates/cli/Cargo.toml
  • crates/committee-hash/Cargo.toml
  • crates/compute-provider/Cargo.toml
  • crates/config/Cargo.toml
  • crates/crypto/Cargo.toml
  • crates/dashboard/Cargo.toml
  • crates/data/Cargo.toml
  • crates/entrypoint/Cargo.toml
  • crates/events/Cargo.toml
  • crates/evm-helpers/Cargo.toml
  • crates/evm/Cargo.toml
  • crates/fhe-params/Cargo.toml
  • crates/fhe/Cargo.toml
  • crates/hamt/Cargo.toml
  • crates/indexer/Cargo.toml
  • crates/init/Cargo.toml
  • crates/interfoldup/Cargo.toml
  • crates/keyshare/Cargo.toml
  • crates/logger/Cargo.toml
  • crates/net/Cargo.toml
  • crates/parity-matrix/Cargo.toml
  • crates/polynomial/Cargo.toml
  • crates/program-server/Cargo.toml
  • crates/request/Cargo.toml
  • crates/safe/Cargo.toml
  • crates/sdk/Cargo.toml
  • crates/slashing/Cargo.toml
  • crates/sortition/Cargo.toml
  • crates/sync/Cargo.toml
  • crates/test-helpers/Cargo.toml
  • crates/tests/Cargo.toml
  • crates/zk-helpers/Cargo.toml

📝 Walkthrough

Walkthrough

The pull request updates 35 crate manifests. Each crate now inherits repository metadata from the workspace. The dashboard manifest now includes the inherited repository field.

Changes

Repository metadata

Layer / File(s) Summary
Workspace repository inheritance
crates/*/Cargo.toml
Crate manifests replace hardcoded repository URLs with repository.workspace = true. The dashboard manifest adds the workspace-inherited repository field.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to d8f60

This updates crate repository metadata to the workspace URL without changing code or runtime behavior; the reported manifest and project checks pass, so no actionable merge-blocking risk remains.

Possibly related PRs

Suggested reviewers: ctrlc03, hmzakhalid, 0xjei

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: aligning crate repository metadata with the workspace URL.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Toby1009

Toby1009 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

test_interfold_init is red, but it is not caused by this change — it fails for any pull request
from a fork, and this PR only edits 35 one-line repository fields, which interfold init never reads.

The job log:

Cloning into '/tmp/__interfold-tmp-folder.1'...
fatal: Remote branch fix/cargo-repository-metadata not found in upstream origin
❌ Error: Git clone failed with exit code: 128

The cause is in .github/workflows/ci.yml:1344: on a pull_request event, github.repository is the
base repo (theinterfold/interfold), while BRANCH comes from github.head_ref, which is the
branch name in the contributor's fork. So the step asks the upstream repository for a branch that only
exists on the fork, and the clone always fails. The step passes on branch pushes within this repo,
which is why it has gone unnoticed.

This is already fixed in #1774, which switches the step to
github.event.pull_request.head.repo.clone_url for pull request events (and routes the values through
env: rather than direct interpolation). Once #1774 lands, this job should go green here on a re-run —
no change is needed in this PR.

For reference, the other two PRs from this same audit (#1796, #1797) are fully green — they do not
trigger this job.

@ctrlc03
ctrlc03 merged commit bc03179 into theinterfold:main Aug 13, 2026
31 of 35 checks passed
@Toby1009
Toby1009 deleted the fix/cargo-repository-metadata branch August 13, 2026 13:12
hmzakhalid pushed a commit that referenced this pull request Aug 16, 2026
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants