Fix ´infer_feature_types´ for 3D EHRData with X=None#246
Merged
Conversation
…layer + the layer=None is hardcoded in _check_feature_types if X is None it goes through layers of the input ehrdata
…ack to preserve variables along the time axis
eroell
reviewed
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
infer_feature_typeswas crashing on 3D EHRData objects whenedata.Xis None and it didnt account for 3D layer when it was passed to the function. This also affected imputation functions decorated with_check_feature_types.tem_data), the function falls through toX = edata.X(which is None) when layer not specified, causing AttributeErrorWith the new changes it falls back to the first available layer when X is None and it vertically stacks timepoints and reshapes to
(n_obs * n_t, n_vars)before building the df when the passed array is 3D.