fix(chart,engine): rename PROTECTOR_FALCO_ADDR -> PROTECTOR_BEHAVIOR_ADDR, drop compat fallback - #333
Merged
thejefflarson merged 2 commits intoAug 8, 2026
Conversation
…ADDR, drop compat fallback The in-repo charts/protector chart now renders PROTECTOR_BEHAVIOR_ADDR only (the engine.falco.* values key and the ...-falco-ingest Service are renamed engine.ingest.* / ...-behavior-ingest to match), and the engine reads only PROTECTOR_BEHAVIOR_ADDR — the deprecated PROTECTOR_FALCO_ADDR compat fallback added in a prior release is deleted (ADR-0014's addenda). The ingestAuth Secret and bearer-token mechanism are unchanged. Scoped to this repo only: the deployed cluster runs a diverged fork of this chart that still sets PROTECTOR_FALCO_ADDR. Porting the rename there, and rolling it out before the fallback-dropped engine, is a separate step tracked outside this repository. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VtjoJttCvBY4dzCoE4f9vP
…-retire-falco-follow-up-rename-chart-protector_falco_addr # Conflicts: # docs/adr/0014-behavioral-telemetry-ebpf.md
thejefflarson
deleted the
thejefflarson/jef-327-retire-falco-follow-up-rename-chart-protector_falco_addr
branch
August 8, 2026 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Falco-retirement cleanup (ADR-0014's addenda). The engine already preferred
PROTECTOR_BEHAVIOR_ADDRand fell back toPROTECTOR_FALCO_ADDR(compat added in aprior release). This PR migrates the in-repo chart to the new name and drops the
now-unneeded fallback:
charts/protector/templates/deployment.yaml— renames thePROTECTOR_FALCO_ADDRenvto
PROTECTOR_BEHAVIOR_ADDR; the container port namefalco-ingest→behavior-ingest.charts/protector/values.yaml— renamesengine.falco.*→engine.ingest.*.charts/protector/templates/engine-services.yaml— renames the…-falco-ingestService →…-behavior-ingest.charts/protector/templates/agent-daemonset.yaml— updates the agent'sPROTECTOR_AGENT_ENDPOINTto point at the renamed Service/port.charts/protector/README.md, rootREADME.md— doc updates to match.docs/adr/0014-behavioral-telemetry-ebpf.md— appends an addendum recording thefallback removal (in the ADR's existing addendum convention).
engine/src/main.rs— drops the.or_else(|_| env::var("PROTECTOR_FALCO_ADDR"))compat fallback; the engine now reads only
PROTECTOR_BEHAVIOR_ADDR.The
ingestAuthSecret + bearer-token mechanism (the agent presents it) isunchanged — only the address/service naming moves.
Scope boundary — NOT included here
../clusterfork is untouched. The deployed cluster runs a diverged fork ofthis chart that still sets
PROTECTOR_FALCO_ADDR. Porting the rename there, andsequencing the deploy so the fork sets
PROTECTOR_BEHAVIOR_ADDRand syncs beforethis fallback-dropped engine rolls (otherwise ingest breaks), is a required separate
step — flagging it for the orchestrator/main loop, not done here.
How I tested it
helm lint charts/protector— clean.helm template charts/protector(default values, and withagent.enabled=true) —confirmed the rendered manifest contains
PROTECTOR_BEHAVIOR_ADDRand the…-behavior-ingestService/port, and noPROTECTOR_FALCO_ADDR/…-falco-ingestanywhere in the output.ingestAuthSecret (…-ingest-auth) andPROTECTOR_INGEST_TOKEN_FILEwiring still render unchanged.cargo fmt -- --check,cargo clippy --all-targets -- -D warnings,cargo test(engine) — all clean/green (1225+10+9+3+1+1 tests passed, 2 ignored).
resolution is a few inline
env::varcalls insiderun()(the binary's asyncentrypoint), not an isolated function — matching this file's existing pattern where
the other trivial env-parsing helpers (
env_or,env_parse) are likewise untestedin isolation. Removing the fallback branch is a straight subtraction of a
no-longer-needed code path;
cargo testconfirms nothing else regressed.Closes JEF-327