fix: bound service map to recent window (was full-table self-join) - #41
Merged
Conversation
Both service-map queries scanned the entire spans table (now 447k rows after expanding tracing): a DISTINCT-service full scan and a child↔parent self-join over everything. A service map is current topology, so bound both to the last hour — ~640x less data, an index scan instead of a full self-join. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service map self-joined the whole spans table (447k rows) with no time bound — slow after the tracing expansion. A service map is current topology, so bound both queries (nodes + edges) to the last hour: index scan over ~700 rows instead of a 447k self-join.