docs: replace thelia:install with the update script in the 3.0 update page - #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3.0 update page told readers to apply database migrations with
php Thelia thelia:install. That command is the initial installer: it callsDatabase::insertSql(), which replayssetup/thelia.sql, and that file starts withDROP TABLE IF EXISTSon every table. Running it on a live shop destroys the data.The page now points at
local/setup/update.php, the script that actually exists for this (it readsthelia_versionfrom the database and replays the update scripts insetup/update/sql/from there), and carries a danger admonition aboutthelia:install.Three other fixes on the same page:
thelia/thelia-skeleton, notthelia/thelia, socomposer update thelia/theliaandcomposer require thelia/thelia:^3.1update nothing;cache:clearboots the container it is about to remove, so the page now documentsrm -rf var/cache/prodfollowed bycache:warmup, and says why skipping the warmup returns a 500 on back-office pages that render a live component;module:refreshnow says what it does, which is comparingmodule.xmlagainst the version stored in the database and running the module'supdate().Applied to both the current docs and the frozen 3.0 version.
npm run buildpasses.