Cut dead build tooling (ponytail cleanup) - #9
Merged
Conversation
- Move-Statement: hand-tokenizes files to reorder #Requires/using statements, but nothing under PSGraph/ uses either; a leftover copy-paste from an unrelated project (BuildTasks/BuildModule.Task.ps1) - Class importer (BuildModule.Task.ps1 and PSGraph.psm1): scans a Classes/ folder that doesn't exist anywhere in the repo - DependsOn module: only used by the two dead class-importers above; dropped from build.ps1 and both CI jobs - deploy.PSDeploy.ps1: PSDeploy DSL never installed by the build pipeline; the actual publish task calls Publish-Module directly - requirements.psd1: DependsOn-format installer for GraphViz 2.38 (2018), unreferenced and superseded by Install-GraphViz.ps1 and ci.yml's own choco/apt/brew steps - PSGraph/Data/Aliases.json: unreferenced by any source file - Pester build task's code-coverage gate: wired up but inert since $Script:CodeCoveragePercent was pinned to 0.0, so the failure branch could never trigger Verified with `Invoke-Build -Task Build` and the full Pester suite (401/401 passing) after the change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014u9G91TefcQ42MAGvWrrqK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Executes the remaining items from
plans/ponytail-cleanup.md(item 7, thespec/folder, was already merged separately in #8):Move-Statement(~115 lines) fromBuildTasks/BuildModule.Task.ps1— hand-tokenizes files to reorder#Requires/usingstatements, but nothing underPSGraph/uses eitherResolve-DependencyOrdercall inBuildModule.Task.ps1, and its duplicate inPSGraph/PSGraph.psm1— both scan aClasses/folder that doesn't exist anywhere in the repoClassesentry from$Script:Folders(BuildTasks/InvokeBuildInit.ps1) now that nothing special-cases itDependsOnmodule dependency frombuild.ps1and both CI jobs — its only call sites were the two dead class-importers abovedeploy.PSDeploy.ps1— PSDeploy DSL never installed by the build pipeline; the publish task callsPublish-Moduledirectlyrequirements.psd1— aDependsOn-format installer for GraphViz 2.38 (2018), unreferenced and superseded byInstall-GraphViz.ps1and CI's own choco/apt/brew stepsPSGraph/Data/Aliases.json— unreferenced by any source file$Script:CodeCoveragePercentwas pinned to0.0, so the failure branch could never trigger). Went with delete rather than setting a real threshold, since picking a coverage % is a policy call — happy to add a real gate back in a follow-up if wanted.Net: -280 lines, -1 module dependency (
DependsOn), no behavior change.Test plan
Invoke-Build -Task Buildsucceeds and produces a correctOutput/PSGraph/PSGraph.psm1🤖 Generated with Claude Code
https://claude.ai/code/session_014u9G91TefcQ42MAGvWrrqK