Skip to content

fix(a11y): Add aria-controls to attribution toggle and list#446

Merged
ianjon3s merged 1 commit intomainfrom
ian/map-attribute-list-id
May 8, 2024
Merged

fix(a11y): Add aria-controls to attribution toggle and list#446
ianjon3s merged 1 commit intomainfrom
ian/map-attribute-list-id

Conversation

@ianjon3s
Copy link
Copy Markdown
Contributor

@ianjon3s ianjon3s commented May 8, 2024

What does this PR do?

Introduces aria-controls to attribution collapse button, and corresponding id to attribution list.

@ianjon3s ianjon3s requested a review from a team May 8, 2024 14:49
@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2024

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit 6bfe3d6
🔍 Latest deploy log https://app.netlify.com/sites/oslmap/deploys/663b910b6e4ad00008cbb0fc
😎 Deploy Preview https://deploy-preview-446--oslmap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to map land 🌐 ✨

@ianjon3s ianjon3s merged commit 0206d83 into main May 8, 2024
@ianjon3s ianjon3s deleted the ian/map-attribute-list-id branch May 8, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants