Skip to content

fix(a11y): Add aria-controls to attribution toggle and list #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianjon3s merged 1 commit into from
May 8, 2024
Merged

fix(a11y): Add aria-controls to attribution toggle and list #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/components/my-map/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,18 @@ export class MyMap extends LitElement {
node.setAttribute("aria-label", node.getAttribute("title") || ""),
);

// Apply aria-controls to attribution button for accessibility
const olAttributionButton: NodeListOf<HTMLButtonElement> | undefined =
this.renderRoot?.querySelectorAll(".ol-attribution button");
olAttributionButton?.forEach((node) =>
node.setAttribute("aria-controls", "ol-attribution-list"),
);

// Apply ID to attribution list for accessibility
const olList: NodeListOf<HTMLElement> | undefined =
this.renderRoot?.querySelectorAll(".ol-attribution ul");
olList?.forEach((node) => node.setAttribute("id", "ol-attribution-list"));

// Re-order overlay elements so that OL Attribution is final element
// making OL Controls first in natural tab order for accessibility
const olAttribution = this.renderRoot?.querySelector(
Expand Down