Utilized SortDirection enum from PHP 8.6#580
Merged
Merged
Conversation
Member
|
@okorneliuk thanks for the PR. While it would be nice to have this inside the package. The CSV package is meant to be used without dependencies so the best course of action would be to update this PR by including the polyfill directly inside the package. |
nyamsprod
reviewed
Jun 30, 2026
nyamsprod
reviewed
Jun 30, 2026
nyamsprod
reviewed
Jun 30, 2026
nyamsprod
reviewed
Jul 1, 2026
Member
|
@okorneliuk I will merge as is your feature and make sure to add your name in the release. But I may update the implementation if needed thanks for the PR and the work 👍🏾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #579
Added a polyfill of upcoming PHP 8.6, used
SortDirectionenum from it instead of private constants inColumn. Slightly extended public API so it is possible to useSortDirectiondirectly insortOnmethod.